Make setup linux action be more friendly with gcp linux runners#96289
Closed
weiwangmeta wants to merge 11 commits intomasterfrom
Closed
Make setup linux action be more friendly with gcp linux runners#96289weiwangmeta wants to merge 11 commits intomasterfrom
weiwangmeta wants to merge 11 commits intomasterfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96289
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit cd43128: BROKEN TRUNK - The following jobs failed but were present on the merge base 3ce1e15:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
huydhn
approved these changes
Mar 8, 2023
Contributor
There was a problem hiding this comment.
LGTM! There are only some minor lint complains. You could also consider updating log classifier rule set https://github.com/pytorch/test-infra/blob/main/aws/lambda/log-classifier/ruleset.toml to string match the error line to show on HUD.
In this case, the curl error showed up first because it's the first rule that mached.
yanboliang
approved these changes
Mar 8, 2023
Contributor
Author
|
@pytorchbot merge -f "failure is not due to this PR" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Fixes issues like the following: https://github.com/pytorch/pytorch/actions/runs/4362155257/jobs/7627059487 has a more serious core dump failure but the log of curl failures (GCP linux trying to get EC2 specific metadata like EC2 AMI-ID, Instance ID, and Instance Type) confused the HUD. <img width="848" alt="image" src="https://user-images.githubusercontent.com/109318740/223670567-330521ba-050a-41c3-9efb-fae6ea3398c0.png"> This PR gets rid of those curl failures. This may have contributed to the impression of "flaky GCP" in #95416 Pull Request resolved: pytorch/pytorch#96289 Approved by: https://github.com/huydhn, https://github.com/yanboliang
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
Fixes issues like the following: https://github.com/pytorch/pytorch/actions/runs/4362155257/jobs/7627059487 has a more serious core dump failure but the log of curl failures (GCP linux trying to get EC2 specific metadata like EC2 AMI-ID, Instance ID, and Instance Type) confused the HUD. <img width="848" alt="image" src="https://user-images.githubusercontent.com/109318740/223670567-330521ba-050a-41c3-9efb-fae6ea3398c0.png"> This PR gets rid of those curl failures. This may have contributed to the impression of "flaky GCP" in #95416 Pull Request resolved: pytorch/pytorch#96289 Approved by: https://github.com/huydhn, https://github.com/yanboliang
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
…rch#96289) Fixes issues like the following: https://github.com/pytorch/pytorch/actions/runs/4362155257/jobs/7627059487 has a more serious core dump failure but the log of curl failures (GCP linux trying to get EC2 specific metadata like EC2 AMI-ID, Instance ID, and Instance Type) confused the HUD. <img width="848" alt="image" src="https://user-images.githubusercontent.com/109318740/223670567-330521ba-050a-41c3-9efb-fae6ea3398c0.png"> This PR gets rid of those curl failures. This may have contributed to the impression of "flaky GCP" in pytorch#95416 Pull Request resolved: pytorch#96289 Approved by: https://github.com/huydhn, https://github.com/yanboliang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues like the following:
https://github.com/pytorch/pytorch/actions/runs/4362155257/jobs/7627059487 has a more serious core dump failure but the log of curl failures (GCP linux trying to get EC2 specific metadata like EC2 AMI-ID, Instance ID, and Instance Type) confused the HUD.
This PR gets rid of those curl failures.
This may have contributed to the impression of "flaky GCP" in #95416
cc @desertfire who first made the request to remove such annoying curl failures.