Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96218
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 90762aa: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jjsjann123
approved these changes
Mar 7, 2023
Collaborator
jjsjann123
left a comment
jjsjann123
left a comment
There was a problem hiding this comment.
Thanks for patching this~~
Collaborator
|
I don't think my stamp mean anything. cc'ing @davidberard98 for a proper stamp/review for merge |
davidberard98
approved these changes
Mar 8, 2023
Contributor
davidberard98
left a comment
davidberard98
left a comment
There was a problem hiding this comment.
mirror @jjsjann123's stamp
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
In csarofeen/pytorch#2517 the return value of `compute_contiguity` is changed from tuple to list. This PR handles that change. Pull Request resolved: pytorch/pytorch#96218 Approved by: https://github.com/jjsjann123, https://github.com/davidberard98
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
In csarofeen/pytorch#2517 the return value of `compute_contiguity` is changed from tuple to list. This PR handles that change. Pull Request resolved: pytorch/pytorch#96218 Approved by: https://github.com/jjsjann123, https://github.com/davidberard98
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
In csarofeen#2517 the return value of `compute_contiguity` is changed from tuple to list. This PR handles that change. Pull Request resolved: pytorch#96218 Approved by: https://github.com/jjsjann123, https://github.com/davidberard98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In csarofeen#2517 the return value of
compute_contiguityis changed from tuple to list. This PR handles that change.cc @kevinstephano @jjsjann123