Skip to content

Retry CI Android emulator test#96163

Closed
huydhn wants to merge 1 commit intopytorch:masterfrom
huydhn:improve-android-ci-reliability
Closed

Retry CI Android emulator test#96163
huydhn wants to merge 1 commit intopytorch:masterfrom
huydhn:improve-android-ci-reliability

Conversation

@huydhn
Copy link
Contributor

@huydhn huydhn commented Mar 7, 2023

This is not the first time I spot Android test flakiness such as
https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227. From some StackOverflow results, it looks like the failure Unknown failure: Error: Could not access the Package Manager. Is the system running? could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-and

So, I'm adding retry capability here to give the test another chance.

@huydhn huydhn added ciflow/trunk Trigger trunk jobs on your pull request test-config/default labels Mar 7, 2023
@huydhn huydhn requested review from a team and ZainRizvi March 7, 2023 02:02
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 7, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96163

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

✅ No Failures

As of commit 7a88995:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@huydhn huydhn marked this pull request as ready for review March 7, 2023 03:02
fi

retry () {
"$@" || (sleep 10 && "$@") || (sleep 20 && "$@") || (sleep 40 && "$@")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it needs to wait for the stuff to load, I'm wondering if we should start with a longer sleep (e.g. start with 20 seconds instead of 10)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I'm not exactly sure what the value should be here, so I opt for the retry more often approach I guess. If the process still fail after 10s, then the next one 10s will hopefully work. We can tweak this value more if somehow this issue still persists after this.

@huydhn
Copy link
Contributor Author

huydhn commented Mar 8, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@huydhn huydhn added the topic: not user facing topic category label Mar 9, 2023
@huydhn
Copy link
Contributor Author

huydhn commented Mar 9, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
This is not the first time I spot Android test flakiness such as
https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227.  From some StackOverflow results, it looks like the failure `Unknown failure: Error: Could not access the Package Manager.  Is the system running?` could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-and

So, I'm adding retry capability here to give the test another chance.
Pull Request resolved: pytorch/pytorch#96163
Approved by: https://github.com/ZainRizvi
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
This is not the first time I spot Android test flakiness such as
https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227.  From some StackOverflow results, it looks like the failure `Unknown failure: Error: Could not access the Package Manager.  Is the system running?` could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-and

So, I'm adding retry capability here to give the test another chance.
Pull Request resolved: pytorch/pytorch#96163
Approved by: https://github.com/ZainRizvi
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
This is not the first time I spot Android test flakiness such as
https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227.  From some StackOverflow results, it looks like the failure `Unknown failure: Error: Could not access the Package Manager.  Is the system running?` could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-and

So, I'm adding retry capability here to give the test another chance.
Pull Request resolved: pytorch#96163
Approved by: https://github.com/ZainRizvi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged test-config/default topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants