Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/96163
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Merge Blocking SEVsThere is 1 active merge blocking SEVs. Please view them below:
If you must merge, use ✅ No FailuresAs of commit 7a88995: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| fi | ||
|
|
||
| retry () { | ||
| "$@" || (sleep 10 && "$@") || (sleep 20 && "$@") || (sleep 40 && "$@") |
There was a problem hiding this comment.
If it needs to wait for the stuff to load, I'm wondering if we should start with a longer sleep (e.g. start with 20 seconds instead of 10)
There was a problem hiding this comment.
Well, I'm not exactly sure what the value should be here, so I opt for the retry more often approach I guess. If the process still fail after 10s, then the next one 10s will hopefully work. We can tweak this value more if somehow this issue still persists after this.
|
@pytorchbot merge |
Merge failedReason: This PR needs a label If not, please add the For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This is not the first time I spot Android test flakiness such as https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227. From some StackOverflow results, it looks like the failure `Unknown failure: Error: Could not access the Package Manager. Is the system running?` could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-and So, I'm adding retry capability here to give the test another chance. Pull Request resolved: pytorch/pytorch#96163 Approved by: https://github.com/ZainRizvi
This is not the first time I spot Android test flakiness such as https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227. From some StackOverflow results, it looks like the failure `Unknown failure: Error: Could not access the Package Manager. Is the system running?` could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-and So, I'm adding retry capability here to give the test another chance. Pull Request resolved: pytorch/pytorch#96163 Approved by: https://github.com/ZainRizvi
This is not the first time I spot Android test flakiness such as https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227. From some StackOverflow results, it looks like the failure `Unknown failure: Error: Could not access the Package Manager. Is the system running?` could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-and So, I'm adding retry capability here to give the test another chance. Pull Request resolved: pytorch#96163 Approved by: https://github.com/ZainRizvi
This is not the first time I spot Android test flakiness such as
https://hud.pytorch.org/pytorch/pytorch/commit/893aa5df3f2a475c91ea8eadb1353812e52fb227. From some StackOverflow results, it looks like the failure
Unknown failure: Error: Could not access the Package Manager. Is the system running?could be fixed by waiting a bit for the emulator to start fully https://stackoverflow.com/questions/15524185/could-not-access-the-package-manager-is-the-system-running-while-installing-andSo, I'm adding retry capability here to give the test another chance.