-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[Caffe2] Eanble python tests on ROCM #9616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@pytorchbot retest this please |
1 similar comment
|
@pytorchbot retest this please |
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bddppq has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
| "${EXTRA_TESTS[@]}" | ||
| # Currently these tests are failing on ROCM platform: | ||
| # Unknown reasons, need to debug |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Thanks we will look into this
Get Outlook for iOS<https://aka.ms/o0ukef>
________________________________
From: bddppq <[email protected]>
Sent: Tuesday, July 24, 2018 3:50 AM
To: pytorch/pytorch
Cc: Yeh, Peter; Mention
Subject: Re: [pytorch/pytorch] [Caffe2] Eanble python tests on ROCM (#9616)
@bddppq commented on this pull request.
________________________________
In .jenkins/caffe2/test.sh<#9616 (comment)>:
- echo "Running Python tests.."
- "$PYTHON" \
- -m pytest \
- -x \
- -v \
- --junit-xml="$TEST_DIR/python/result.xml" \
- --ignore "$CAFFE2_PYPATH/python/test/executor_test.py" \
- --ignore "$CAFFE2_PYPATH/python/operator_test/matmul_op_test.py" \
- --ignore "$CAFFE2_PYPATH/python/operator_test/pack_ops_test.py" \
- --ignore "$CAFFE2_PYPATH/python/mkl/mkl_sbn_speed_test.py" \
- ${conda_ignore_test[@]} \
- "$CAFFE2_PYPATH/python" \
- "${EXTRA_TESTS[@]}"
+ # Currently these tests are failing on ROCM platform:
+
+ # Unknown reasons, need to debug
@petrex<https://github.com/petrex> @ashishfarmer<https://github.com/ashishfarmer>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#9616 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAqt_xE4TUJcD1xARrTE_2Io0mZdAbbQks5uJvv9gaJpZM4VXbbX>.
|
| "caffe2/transforms/*", | ||
| "caffe2/video/*", | ||
| "caffe2/distributed/*", | ||
| "caffe2/queue/*", |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Summary: petrex Pull Request resolved: pytorch#9616 Differential Revision: D8960623 Pulled By: bddppq fbshipit-source-id: bde93bda6230094e6bf4badd8ee79f0688ae1993
Summary: petrex Pull Request resolved: pytorch#9616 Differential Revision: D8960623 Pulled By: bddppq fbshipit-source-id: bde93bda6230094e6bf4badd8ee79f0688ae1993
And automatically hipify all c++ tests
@petrex