Skip to content

Improve ArrayRef #9610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
smessmer wants to merge 1 commit into from
Closed

Improve ArrayRef #9610

smessmer wants to merge 1 commit into from

Conversation

@smessmer
Copy link
Contributor

@smessmer smessmer commented Jul 20, 2018

Summary: Mostly making some stuff in ArrayRef constexpr to give it better perf.

Differential Revision: D8926785

@colesbury
Copy link
Member

colesbury commented Jul 20, 2018

In what sort of use cases did you see a performance improvement?

@smessmer
Copy link
Contributor Author

smessmer commented Jul 23, 2018 •
edited
Loading

Sorry, I probably formulated that a bit misleadingly. It doesn't improve perf for existing use cases, but it allows ArrayRef to be used in constexpr environments in future (for example for c10).

Constexpr per se doesn't improve perf. Some expressions can be evaluated at compile time and some cannot. For expressions that can be evaluated at compile time, many compilers will do so, even if you don't add the "constexpr" keyword. What the "constexpr" keyword does is it asserts that the expression can be evaluated at compile time. So it makes sure that the stuff you want to be run at compile time actually can be done so. And it needs to be added to functions or methods if you want to call them from a constexpr environment (i.e. from another function or method that is constexpr).

@smessmer smessmer requested review from pietern and teng-li as code owners July 23, 2018 23:36
@smessmer smessmer mentioned this pull request Jul 24, 2018
Closed
@smessmer @facebook-github-bot
Improve ArrayRef (pytorch#9610)
dc0eb6f 
Summary:
Pull Request resolved: pytorch#9610

Mostly making some stuff in ArrayRef constexpr to give it better perf.

Differential Revision: D8926785

fbshipit-source-id: 5403e86e4b1849718f24f0c79b6e70380b3eceaa
zdevito pushed a commit to zdevito/ATen that referenced this pull request Aug 1, 2018
@smessmer @facebook-github-bot
Improve ArrayRef (#9610)
70a42cb 
Summary:
Pull Request resolved: pytorch/pytorch#9610

Mostly making some stuff in ArrayRef constexpr to give it better perf.

Reviewed By: ezyang

Differential Revision: D8926785

fbshipit-source-id: af6d4b05fbc69d20855a80f3edc2b501577a742b
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@smessmer
Improve ArrayRef (pytorch#9610)
90a3159 
Summary:
Pull Request resolved: pytorch#9610

Mostly making some stuff in ArrayRef constexpr to give it better perf.

Reviewed By: ezyang

Differential Revision: D8926785

fbshipit-source-id: af6d4b05fbc69d20855a80f3edc2b501577a742b
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang left review comments

@apaszke apaszke Awaiting requested review from apaszke

@colesbury colesbury Awaiting requested review from colesbury

@gchanan gchanan Awaiting requested review from gchanan

@soumith soumith Awaiting requested review from soumith

@zdevito zdevito Awaiting requested review from zdevito

@pietern pietern Awaiting requested review from pietern

@teng-li teng-li Awaiting requested review from teng-li

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smessmer @colesbury @bddppq @ezyang