Add operator<< overloads for TensorOptions #9606
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goldsborough
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
ebetica
approved these changes
Jul 19, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@goldsborough has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
Author
|
@pytorchbot retest this please |
2 similar comments
Contributor
Author
|
@pytorchbot retest this please |
Contributor
Author
|
@pytorchbot retest this please |
goldsborough
force-pushed
the
tensor-options-cout
branch
from
da52faa to
2b320e4
Compare
ezyang
reviewed
Jul 23, 2018
aten/src/ATen/Layout.h
Outdated
| } // namespace at | ||
|
|
||
| inline std::ostream& operator<<(std::ostream& stream, at::Layout layout) { | ||
| return stream << ((layout == at::kStrided) ? "Strided" : "Sparse"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
ezyang
approved these changes
Jul 23, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Approved with nits fixed.
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@goldsborough is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 23, 2018
Summary: Added `operator<<` overloads for `at::TensorOptions` on request of ebetica Example output: ``` TensorOptions(dtype=Double, device=cpu, layout=Strided, requires_grad=false) ``` ezyang apaszke Pull Request resolved: pytorch/pytorch#9606 Differential Revision: D8925191 Pulled By: goldsborough fbshipit-source-id: 0503bc2851268276e9561d918290bc723e437c9c
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Added `operator<<` overloads for `at::TensorOptions` on request of ebetica Example output: ``` TensorOptions(dtype=Double, device=cpu, layout=Strided, requires_grad=false) ``` ezyang apaszke Pull Request resolved: pytorch#9606 Differential Revision: D8925191 Pulled By: goldsborough fbshipit-source-id: 0503bc2851268276e9561d918290bc723e437c9c
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Added `operator<<` overloads for `at::TensorOptions` on request of ebetica Example output: ``` TensorOptions(dtype=Double, device=cpu, layout=Strided, requires_grad=false) ``` ezyang apaszke Pull Request resolved: pytorch#9606 Differential Revision: D8925191 Pulled By: goldsborough fbshipit-source-id: 0503bc2851268276e9561d918290bc723e437c9c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
operator<<overloads forat::TensorOptionson request of @ebeticaExample output:
@ezyang @apaszke