Constexpr Type Ids -> 6.5% caffe2 perf improvement #9603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smessmer
force-pushed
the
export-D8841577
branch
from
f7c3e1a to
a89562d
Compare
Summary: Pull Request resolved: pytorch#9603 Using constexpr for some heavily queried type ids gives us a 6.5% perf improvement for caffe2. Benchmark results: P59829647 Differential Revision: D8841577 fbshipit-source-id: 1ce5e4eaba47f4304f2ef35507f5a25e5779c798
smessmer
force-pushed
the
export-D8841577
branch
from
a89562d to
93e66a7
Compare
dzhulgakov
approved these changes
Jul 24, 2018
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 30, 2018
Summary: Pull Request resolved: pytorch#9603 Using constexpr for some heavily queried type ids gives us a 6.5% perf improvement for caffe2. Benchmark results: P59829647 Also ad canaries (but they don't show a significant difference): - adfinder: - https://our.intern.facebook.com/intern/ads/canary/411346509423301481 - https://our.intern.facebook.com/intern/ads/canary/411346563021753557 - adindexer: - https://our.intern.facebook.com/intern/ads/canary/411346517006038367 - https://our.intern.facebook.com/intern/ads/canary/411346571387258927 - multifeed_predictor: - https://our.intern.facebook.com/intern/ads/canary/411346526631282941 - https://our.intern.facebook.com/intern/ads/canary/411346583141009531 Reviewed By: dzhulgakov Differential Revision: D8841577 fbshipit-source-id: 1a0ce7f2bee1ae54b723caefe5bc7f85a20935b4
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9603 Using constexpr for some heavily queried type ids gives us a 6.5% perf improvement for caffe2. Benchmark results: P59829647 Also ad canaries (but they don't show a significant difference): - adfinder: - https://our.intern.facebook.com/intern/ads/canary/411346509423301481 - https://our.intern.facebook.com/intern/ads/canary/411346563021753557 - adindexer: - https://our.intern.facebook.com/intern/ads/canary/411346517006038367 - https://our.intern.facebook.com/intern/ads/canary/411346571387258927 - multifeed_predictor: - https://our.intern.facebook.com/intern/ads/canary/411346526631282941 - https://our.intern.facebook.com/intern/ads/canary/411346583141009531 Reviewed By: dzhulgakov Differential Revision: D8841577 fbshipit-source-id: 1a0ce7f2bee1ae54b723caefe5bc7f85a20935b4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Using constexpr for some heavily queried type ids gives us a 6.5% perf improvement for caffe2.
Benchmark results: P59829647
Differential Revision: D8841577