Skip to content

Conversation

@desertfire
Copy link
Contributor

@desertfire desertfire commented Mar 3, 2023

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95985

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Merge Blocking SEVs

There is 1 active merge blocking SEVs. Please view them below:

If you must merge, use @pytorchbot merge -f.

❌ 1 Failures

As of commit ad96097:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

desertfire added a commit that referenced this pull request Mar 3, 2023
Summary: This is a reland of #94822

ghstack-source-id: 5b36e6a
Pull Request resolved: #95985
@desertfire
Copy link
Contributor Author

@pytorchbot rebase

@desertfire desertfire added the topic: not user facing topic category label Mar 5, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict gh/desertfire/80/orig returned non-zero exit code 1

Rebasing (1/1)
Auto-merging benchmarks/dynamo/common.py
Auto-merging torch/_inductor/__init__.py
CONFLICT (content): Merge conflict in torch/_inductor/__init__.py
Auto-merging torch/_inductor/codecache.py
Auto-merging torch/_inductor/codegen/cpp.py
Auto-merging torch/_inductor/config.py
CONFLICT (content): Merge conflict in torch/_inductor/config.py
Auto-merging torch/_inductor/graph.py
error: could not apply 1a33bf86067... [reland][inductor] Add an AOT compilation mode for Inductor CPP backend
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply 1a33bf86067... [reland][inductor] Add an AOT compilation mode for Inductor CPP backend

Raised by https://github.com/pytorch/pytorch/actions/runs/4336828967

…r CPP backend"

Summary: This is a reland of #94822

cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Mar 5, 2023
Summary: This is a reland of #94822

ghstack-source-id: 1aa9136
Pull Request resolved: #95985
@desertfire
Copy link
Contributor Author

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

…r CPP backend"

Summary: This is a reland of #94822

cc soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

Successfully rebased gh/desertfire/80/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/95985)

pytorchmergebot pushed a commit that referenced this pull request Mar 7, 2023
Summary: This is a reland of #94822

ghstack-source-id: dc88f33
Pull Request resolved: #95985
@desertfire desertfire requested a review from jansel March 7, 2023 17:26
@desertfire
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 7, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@desertfire
Copy link
Contributor Author

@pytorchbot merge -f "macos test is flaky"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@huydhn
Copy link
Contributor

huydhn commented Mar 9, 2023

@pytorchbot revert -m 'Sorry for reverting this. It increased the test time significantly for ASAN (and may be other test shards). ASAN tests on PR passed but it was barely not timing out. I have updated my initial findings in #96378' -c weird

@pytorch pytorch deleted a comment from pytorch-bot bot Mar 9, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@desertfire your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Mar 9, 2023
…PP backend (#95985)"

This reverts commit deaf9e5.

Reverted #95985 on behalf of https://github.com/huydhn due to Sorry for reverting this. It increased the test time significantly for ASAN (and may be other test shards). ASAN tests on PR passed but it was barely not timing out. I have updated my initial findings in #96378
@malfet
Copy link
Contributor

malfet commented Mar 9, 2023

Please note, that it also added about 2h of test time to MacOS x86 shards and about 30 min of test time to MacOS M1. Does this change really need such exhaustive testing?

@desertfire
Copy link
Contributor Author

I think it only affected CPU tests. Let me look into it.

@desertfire desertfire closed this Mar 10, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
…PP backend (#95985)"

This reverts commit deaf9e5.

Reverted pytorch/pytorch#95985 on behalf of https://github.com/huydhn due to Sorry for reverting this. It increased the test time significantly for ASAN (and may be other test shards). ASAN tests on PR passed but it was barely not timing out. I have updated my initial findings in pytorch/pytorch#96378
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
…PP backend (#95985)"

This reverts commit deaf9e5.

Reverted pytorch/pytorch#95985 on behalf of https://github.com/huydhn due to Sorry for reverting this. It increased the test time significantly for ASAN (and may be other test shards). ASAN tests on PR passed but it was barely not timing out. I have updated my initial findings in pytorch/pytorch#96378
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
…PP backend (pytorch#95985)"

This reverts commit deaf9e5.

Reverted pytorch#95985 on behalf of https://github.com/huydhn due to Sorry for reverting this. It increased the test time significantly for ASAN (and may be other test shards). ASAN tests on PR passed but it was barely not timing out. I have updated my initial findings in pytorch#96378
@facebook-github-bot facebook-github-bot deleted the gh/desertfire/80/head branch June 8, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants