Skip to content

[5/N][BE] Remove Replicated Tensor class#95947

Closed
fduwjj wants to merge 1 commit intogh/fduwjj/77/basefrom
gh/fduwjj/77/head
Closed

[5/N][BE] Remove Replicated Tensor class#95947
fduwjj wants to merge 1 commit intogh/fduwjj/77/basefrom
gh/fduwjj/77/head

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Mar 3, 2023 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 3, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95947

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit baaf5cc:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Mar 3, 2023
Closed
Closed
@fduwjj fduwjj added better-engineering Relatively self-contained tasks for better engineering contributors release notes: distributed (sharded) release notes category labels Mar 3, 2023
@fduwjj fduwjj changed the title [5/N] Remove Replicated Tensor class [5/N][BE] Remove Replicated Tensor class Mar 3, 2023
@fduwjj fduwjj added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 6, 2023
wanchaol
wanchaol approved these changes Mar 6, 2023
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Do you check if internal/external are using this already?

@fduwjj
Copy link
Contributor Author

fduwjj commented Mar 6, 2023 •
edited
Loading

@wanchaol no internal use case found for ReplicatedTensor. I am not sure about external at least not I am aware of.

@wanchaol
Copy link
Collaborator

wanchaol commented Mar 6, 2023

sounds good, yeah let's ship it then ;)

@fduwjj
Copy link
Contributor Author

fduwjj commented Mar 6, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 6, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@fduwjj
Copy link
Contributor Author

fduwjj commented Mar 7, 2023

@fduwjj has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@fduwjj @cyyever
[5/N][BE] Remove Replicated Tensor class (#95947)
4f871c5 
Pull Request resolved: pytorch/pytorch#95947
Approved by: https://github.com/wanchaol
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@fduwjj @cyyever
[5/N][BE] Remove Replicated Tensor class (#95947)
16d7a47 
Pull Request resolved: pytorch/pytorch#95947
Approved by: https://github.com/wanchaol
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
[5/N][BE] Remove Replicated Tensor class (pytorch#95947)
cae627e 
Pull Request resolved: pytorch#95947
Approved by: https://github.com/wanchaol
@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/77/head branch June 8, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanchaol wanchaol wanchaol approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@fegin fegin Awaiting requested review from fegin

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (sharded) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fduwjj @wanchaol @pytorchmergebot