Skip to content

Follow up on CUDA 12 support for PyTorch/Caffe2#95582

Closed
jianyuh wants to merge 1 commit intopytorch:masterfrom
jianyuh:export-D43610669
Closed

Follow up on CUDA 12 support for PyTorch/Caffe2#95582
jianyuh wants to merge 1 commit intopytorch:masterfrom
jianyuh:export-D43610669

Conversation

@jianyuh
Copy link
Member

@jianyuh jianyuh commented Feb 26, 2023

Differential Revision: D43610669

cc @ngimel

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95582

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a2801ef:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43610669

@jianyuh jianyuh added module: cuda Related to torch.cuda, and CUDA support in general ciflow/trunk Trigger trunk jobs on your pull request release notes: cuda release notes category labels Feb 26, 2023
@jianyuh
Copy link
Member Author

jianyuh commented Feb 26, 2023

@pytorchbot merge

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43610669

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43610669

jianyuh added a commit to jianyuh/pytorch that referenced this pull request Feb 26, 2023
Summary:
Pull Request resolved: pytorch#95582

Requested by pytorch#91122 (comment)

Test Plan: As title

Differential Revision: D43610669

fbshipit-source-id: a3a8cd6b145706c1080b009d5d58e66fd909db6a
@jianyuh
Copy link
Member Author

jianyuh commented Feb 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Summary:
Pull Request resolved: pytorch#95582

Requested by pytorch#91122 (comment)

Test Plan: As title

Differential Revision: D43610669

fbshipit-source-id: b9f9c331613c6a77ae561c9efe684f95d436c4de
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43610669

@jianyuh
Copy link
Member Author

jianyuh commented Feb 27, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@xkszltl
Copy link
Contributor

xkszltl commented Feb 27, 2023

Regarding the comment, my understanding is it's no longer supported, instead of "not needed". It was used to set profilng options and now they cannot be set in code, so there's behavior change.

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
jhavukainen pushed a commit to kulinseth/pytorch that referenced this pull request Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged module: cuda Related to torch.cuda, and CUDA support in general release notes: cuda release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants