[ready] Add multivariate log-gamma (mvlgamma) #9451
Conversation
1. Add tests in test_cuda, test_torch 2. Add doc strings
vishwakftw
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith,
ssnl,
zdevito and
zou3519
as code owners
vishwakftw
force-pushed
the
multivariate-gamma
branch
from
86929a6 to
c0c7f62
Compare
vishwakftw
force-pushed
the
multivariate-gamma
branch
from
c0c7f62 to
fb45401
Compare
|
@pytorchbot retest this please |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
aten/src/ATen/native/UnaryOps.cpp
Outdated
| "mvlgamma is not implemented for ", self.type()); | ||
| AT_CHECK((self > 0.5 * (p - 1.)).all().toCByte(), | ||
| "Condition for computing multivariate log-gamma not met"); | ||
| AT_CHECK(p >= 1, "p has to greater than or equal to 1"); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| "Condition for computing multivariate log-gamma not met"); | ||
| AT_CHECK(p >= 1, "p has to be greater than or equal to 1"); | ||
| Tensor args = native::arange(-p + 1, 1, self.options()).div_(2.); | ||
| args = args.add(self.unsqueeze(-1)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
aten/src/ATen/native/UnaryOps.cpp
Outdated
| AT_CHECK((self > 0.5 * (p - 1.)).all().toCByte(), | ||
| "Condition for computing multivariate log-gamma not met"); | ||
| AT_CHECK(p >= 1, "p has to be greater than or equal to 1"); | ||
| Tensor args = native::arange(-p + 1, 1, self.options()).div_(2.); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Is this good to go? Sorry about the reminder. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
vishwakftw
changed the title
Summary: 1. Add tests in test_cuda, test_torch 2. Add doc strings Closes #9378 . Differential Revision: D8859746 Pulled By: ezyang fbshipit-source-id: 939c309d90940a7aa08f53004c9e7b3b1c9cf54e
Summary: 1. Add tests in test_cuda, test_torch 2. Add doc strings Closes pytorch#9378 . Differential Revision: D8859746 Pulled By: ezyang fbshipit-source-id: 939c309d90940a7aa08f53004c9e7b3b1c9cf54e
Summary: 1. Add tests in test_cuda, test_torch 2. Add doc strings Closes pytorch#9378 . Differential Revision: D8859746 Pulled By: ezyang fbshipit-source-id: 939c309d90940a7aa08f53004c9e7b3b1c9cf54e
4 participants
Closes #9378 .
cc: @alicanb