Skip to content

Fix scalar type resolution for optional tensor#94427

Closed
thiagocrepaldi wants to merge 1 commit intopytorch:masterfrom
thiagocrepaldi:thiagofc/fix-_op_with_optional_float_cast
Closed

Fix scalar type resolution for optional tensor#94427
thiagocrepaldi wants to merge 1 commit intopytorch:masterfrom
thiagocrepaldi:thiagofc/fix-_op_with_optional_float_cast

Conversation

@thiagocrepaldi
Copy link
Copy Markdown
Collaborator

@thiagocrepaldi thiagocrepaldi commented Feb 8, 2023

When TorchScript Value has an optional tensor, dtype() or scalarType() is not available and raise (by design).

The symbolic _op_with_optional_float_cast must check whether the tensor is otpional or not before calling the scalar type resolution API. This PR fixes that

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Feb 8, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94427

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit f0c231c:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 8, 2023
@thiagocrepaldi thiagocrepaldi self-assigned this Feb 8, 2023
@thiagocrepaldi thiagocrepaldi added the module: onnx Related to torch.onnx label Feb 8, 2023
@thiagocrepaldi
Copy link
Copy Markdown
Collaborator Author

thiagocrepaldi commented Feb 8, 2023

@pytorch merge -g

@thiagocrepaldi thiagocrepaldi mentioned this pull request Feb 8, 2023
Closed
@thiagocrepaldi
Copy link
Copy Markdown
Collaborator Author

thiagocrepaldi commented Feb 8, 2023

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 8, 2023
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 8, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 8, 2023

Merge failed

Reason: 2 mandatory check(s) failed (Rule ONNX exporter). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@thiagocrepaldi thiagocrepaldi force-pushed the thiagofc/fix-_op_with_optional_float_cast branch from 9d4b8fb to e54369a Compare February 8, 2023 19:47
shubhambhokare1
shubhambhokare1 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@shubhambhokare1 shubhambhokare1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fix lint issues?

@thiagocrepaldi thiagocrepaldi force-pushed the thiagofc/fix-_op_with_optional_float_cast branch from e54369a to f0c231c Compare February 8, 2023 22:36
@thiagocrepaldi

This comment was marked as outdated.

Sign in to view
@pytorch-bot

This comment was marked as outdated.

Sign in to view
@thiagocrepaldi
Copy link
Copy Markdown
Collaborator Author

thiagocrepaldi commented Feb 9, 2023

@pytorchbot merge -f "Unrelated lint failure: python3: can't open file '/home/runner/work/pytorch/pytorch/.github/scripts/collect_ciflow_labels.py': [Errno 2] No such file or directory"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Feb 9, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@thiagocrepaldi thiagocrepaldi added this to the 2.0.0 milestone Feb 9, 2023
@thiagocrepaldi thiagocrepaldi deleted the thiagofc/fix-_op_with_optional_float_cast branch May 4, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shubhambhokare1 shubhambhokare1 shubhambhokare1 approved these changes

@BowenBao BowenBao Awaiting requested review from BowenBao

+1 more reviewer

@abock abock abock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thiagocrepaldi thiagocrepaldi

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@thiagocrepaldi @pytorchmergebot @abock @shubhambhokare1 @pytorchbot