Move non-dimension reduction var/std to native wrappers. #9400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to unify the handling of empty tensors in std/var between the dimension reduce and all reduce cases. Also to avoid triggering ubsan errors around divide by 0.
gchanan
requested review from
apaszke,
colesbury,
ezyang,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@gchanan has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ezyang
approved these changes
Jul 13, 2018
Contributor
ezyang
left a comment
ezyang
left a comment
There was a problem hiding this comment.
Are there some UBSAN exclusions we get to remove now?
Contributor
Author
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: This is to unify the handling of empty tensors in std/var between the dimension reduce and all reduce cases. Also to avoid triggering ubsan errors around divide by 0. Pull Request resolved: pytorch/pytorch#9400 Reviewed By: ezyang Differential Revision: D8828879 Pulled By: gchanan fbshipit-source-id: 6b9306805c94251eec28bd12e234618338bff4e3
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 13, 2018
Summary: This is to unify the handling of empty tensors in std/var between the dimension reduce and all reduce cases. Also to avoid triggering ubsan errors around divide by 0. Pull Request resolved: pytorch/pytorch#9400 Reviewed By: ezyang Differential Revision: D8828879 Pulled By: gchanan fbshipit-source-id: 6b9306805c94251eec28bd12e234618338bff4e3
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: This is to unify the handling of empty tensors in std/var between the dimension reduce and all reduce cases. Also to avoid triggering ubsan errors around divide by 0. Pull Request resolved: pytorch#9400 Reviewed By: ezyang Differential Revision: D8828879 Pulled By: gchanan fbshipit-source-id: 6b9306805c94251eec28bd12e234618338bff4e3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unify the handling of empty tensors in std/var between the dimension reduce and all reduce cases.
Also to avoid triggering ubsan errors around divide by 0.