Skip to content

Refactor to allow reuse of SchedulerNode.allocate #93328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wconstab wants to merge 8 commits into from
Closed

Refactor to allow reuse of SchedulerNode.allocate #93328

wconstab wants to merge 8 commits into from

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Jan 31, 2023 •
edited
Loading

@wconstab
Refactor to allow reuse of SchedulerNode.allocate
8ed2fb2 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 31, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93328

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 53c0d92:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wconstab added a commit that referenced this pull request Jan 31, 2023
@wconstab
Refactor to allow reuse of SchedulerNode.allocate
0b74c29 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

ghstack-source-id: 0eb5430
Pull Request resolved: #93328
@wconstab wconstab mentioned this pull request Jan 31, 2023
Closed
@wconstab wconstab added the topic: not user facing topic category label Jan 31, 2023
@wconstab
Update on "Refactor to allow reuse of SchedulerNode.allocate"
26efa95 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@wconstab
Update on "Refactor to allow reuse of SchedulerNode.allocate"
868bf28 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@wconstab
Update on "Refactor to allow reuse of SchedulerNode.allocate"
edd170b 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@wconstab wconstab requested a review from jansel February 1, 2023 01:32
@wconstab
Copy link
Contributor Author

wconstab commented Feb 1, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 1, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x da79826994cd36f12d18a2dbaf26ef3da564b728 returned non-zero exit code 1

Auto-merging torch/_inductor/scheduler.py
CONFLICT (content): Merge conflict in torch/_inductor/scheduler.py
error: could not apply da79826994... Refactor to allow reuse of SchedulerNode.allocate
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
Details for Dev Infra team Raised by workflow job

@wconstab
Update on "Refactor to allow reuse of SchedulerNode.allocate"
3e5fab1 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@wconstab
Copy link
Contributor Author

wconstab commented Feb 1, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-12-py3-x86-64 / build

Details for Dev Infra team Raised by workflow job

@wconstab
Update on "Refactor to allow reuse of SchedulerNode.allocate"
c326b9d 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@wconstab
Copy link
Contributor Author

wconstab commented Feb 2, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 2, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 2, 2023

Merge failed

Reason: 2 mandatory check(s) failed (Rule superuser). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@wconstab
Update on "Refactor to allow reuse of SchedulerNode.allocate"
d181bc1 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
This was referenced Feb 2, 2023
Closed
Closed
Closed
Closed
Closed
@wconstab wconstab mentioned this pull request Feb 2, 2023
Closed
@wconstab
Update on "Refactor to allow reuse of SchedulerNode.allocate"
53c0d92 
Paves the way for ExternKernelSchedulerNode to also be able to
use the buffer inplace logic, needed for Collective ops.

cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx peterbell10 desertfire

[ghstack-poisoned]
@wconstab
Copy link
Contributor Author

wconstab commented Feb 2, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 2, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 2, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-focal-rocm5.4.2-py3.8 / test (default, 2, 2, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

ragulpr added a commit to ragulpr/pytorch that referenced this pull request Feb 2, 2023
@ragulpr
Merge remote-tracking branch 'origin' into ragulpr/requirements-txt-i…
e30a5ca 
…n-dev-setup

* origin: (898 commits)
  Move dynamo.optimizations.distributed to backends (pytorch#93408)
  Remove cuda 11.6 from nightly (pytorch#93979)
  Refactor dynamo register_backend/BACKENDS (pytorch#93389)
  Remove cuda 11.6 from CI replace with 11.7 (pytorch#93406)
  [Dynamo] Rename `GuardBuilder.guarded_code` -> `check_fn_manager` (pytorch#93934)
  Revert "Remove CUDA 11.6 from nightly builds (pytorch#93404)"
  Revert "[inductor] fix crash issue when input is a view tensor (pytorch#90150)"
  Basic Validation for FSDP `state_dict` transformations of modules with persistent buffers (pytorch#93396)
  Merge Inductor perf smoke test with other inductor CI tests (pytorch#93395)
  [inductor] Don't import torchvision (pytorch#93027)
  [FSDP][3/N] Refactor `summon_full_params` unit tests (pytorch#92298)
  [FSDP][2/N] `_summon_full_params` -> `_unshard_params` (pytorch#92297)
  Remove CUDA 11.6 from nightly builds (pytorch#93404)
  Mark buffers that reuse other buffers (pytorch#93329)
  Refactor to allow reuse of SchedulerNode.allocate (pytorch#93328)
  retire sparse_mask_helper (pytorch#91714)
  update fbgemm third party (pytorch#93907)
  [inductor] fix crash issue when input is a view tensor (pytorch#90150)
  [Inductor] add config for weight prepacking (pytorch#93811)
  Check for none for NNModuleVariable.__module__ (pytorch#93326)
  ...
@facebook-github-bot facebook-github-bot deleted the gh/wconstab/84/head branch June 8, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wconstab @pytorchmergebot @jansel