[Fix] Plotting embeddings norm being slow in distributed training. #9325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: as title. Fixing by calculating norm on same device. Differential Revision: D8668136 fbshipit-source-id: 7706cdfc13755ec7df74e4aa487d12a31e1f5dd5
Contributor
|
@pytorchbot retest this please |
alex1o1o7cloud
changed the title
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…#9325) Summary: Pull Request resolved: pytorch#9325 as title. Fixing by calculating norm on same device. Reviewed By: chocjy Differential Revision: D8668136 fbshipit-source-id: 6671a1858da4b0a6f766f067b7fa648a072cd219
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: as title. Fixing by calculating norm on same device.
Differential Revision: D8668136