Skip to content

Conversation

@orionr
Copy link
Contributor

@orionr orionr commented Jul 9, 2018

Breaking this out of #8338

More changes required to support USE_CUDNN=OFF. We should be able to land some of our fixes before the big BUILD_CAFFE2 and BUILD_ATEN removal lands.

cc @mingzhe09088 @Yangqing

Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@orionr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@orionr
Copy link
Contributor Author

orionr commented Jul 9, 2018

@pytorchbot retest this please

Copy link
Contributor

@mingzhe09088 mingzhe09088 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
Summary:
Breaking this out of pytorch#8338

More changes required to support USE_CUDNN=OFF. We should be able to land some of our fixes before the big BUILD_CAFFE2 and BUILD_ATEN removal lands.

cc mingzhe09088 Yangqing
Pull Request resolved: pytorch#9268

Reviewed By: mingzhe09088

Differential Revision: D8767981

Pulled By: orionr

fbshipit-source-id: 0607ca2773253b685209c274a3adf70180d8ce58
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants