-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[Reland] Add sym_size/stride/numel/storage_offset to native_function.yaml (#91… #92402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92402
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 0a1356b: BROKEN TRUNK - The following jobs failed but were present on the merge base 438f12d:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
ezyang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping me if you need more review
|
This pull request was exported from Phabricator. Differential Revision: D42565586 |
eeb698e to
274d439
Compare
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: f0ea5a7e60b2293ac11b3d4fcc88337c36f2ba08
274d439 to
a4eca9b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42565586 |
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
|
This pull request was exported from Phabricator. Differential Revision: D42565586 |
a4eca9b to
0a1356b
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
This diff regressed one pretty important model we have for export, and we did our best to fix forward today. Unfortunately, it seems we need more time to investigate the interaction between this diff and inference mode. Meanwhile to unblock our model enablement work, we may need to revert this diff. |
|
@pytorchbot revert -m "Caused a regression for an export model." -c landrace |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@SherlockNoMad your PR has been successfully reverted. |
…unction.yaml (#91… (#92402)" This reverts commit 965f4ea. Reverted #92402 on behalf of https://github.com/zhxchen17 due to Caused a regression for an export model.
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
#100749) …yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492 Fixes #ISSUE_NUMBER Pull Request resolved: #100749 Approved by: https://github.com/zhxchen17, https://github.com/albanD
#91919) Summary: …yaml (https://github.com/pytorch/pytorch/issues/91… (#91919) Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492 Fixes #ISSUE_NUMBER cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire Pull Request resolved: #100749 SherlockNoMad Differential Revision: D45620400 fbshipit-source-id: 82fafda359febdf9246f63a1355e376ecf17d5cb
Pull Request resolved: #91919
Approved by: https://github.com/ezyang
Fixes #ISSUE_NUMBER