Skip to content

Conversation

@SherlockNoMad
Copy link
Contributor

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 18, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92402

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 0a1356b:

BROKEN TRUNK - The following jobs failed but were present on the merge base 438f12d:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

@SherlockNoMad has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@albanD albanD removed their request for review January 18, 2023 16:04
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping me if you need more review

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42565586

SherlockNoMad added a commit that referenced this pull request Jan 27, 2023
…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: f0ea5a7e60b2293ac11b3d4fcc88337c36f2ba08
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42565586

…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D42565586

@SherlockNoMad SherlockNoMad added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 31, 2023
@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@zhxchen17
Copy link
Contributor

This diff regressed one pretty important model we have for export, and we did our best to fix forward today. Unfortunately, it seems we need more time to investigate the interaction between this diff and inference mode. Meanwhile to unblock our model enablement work, we may need to revert this diff.

cc @SherlockNoMad

@zhxchen17
Copy link
Contributor

@pytorchbot revert -m "Caused a regression for an export model." -c landrace

@pytorch pytorch deleted a comment from pytorch-bot bot Feb 3, 2023
@pytorch pytorch deleted a comment from pytorch-bot bot Feb 3, 2023
@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@SherlockNoMad your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Feb 3, 2023
SherlockNoMad added a commit that referenced this pull request May 5, 2023
…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492
SherlockNoMad added a commit that referenced this pull request May 8, 2023
…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492
SherlockNoMad added a commit that referenced this pull request May 9, 2023
…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492
pytorchmergebot pushed a commit that referenced this pull request May 10, 2023
…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492
pytorchmergebot pushed a commit that referenced this pull request May 11, 2023
…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492
pytorchmergebot pushed a commit that referenced this pull request May 12, 2023
…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919
Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492
pytorchmergebot pushed a commit that referenced this pull request May 12, 2023
#100749)

…yaml (#91… (#91919)

Summary:
Pull Request resolved: #91919 Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Reviewed By: ezyang

Differential Revision: D42565586

Pulled By: SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492

Fixes #ISSUE_NUMBER

Pull Request resolved: #100749
Approved by: https://github.com/zhxchen17, https://github.com/albanD
SherlockNoMad added a commit that referenced this pull request Jun 6, 2023
#91919)

Summary:
…yaml (https://github.com/pytorch/pytorch/issues/91… (#91919)
Pull Request resolved: #91919 Approved by: https://github.com/ezyang

Fixes #ISSUE_NUMBER

Pull Request resolved: #92402

Pulled By:
SherlockNoMad

fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
ghstack-source-id: 969f492

Fixes #ISSUE_NUMBER

cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire

Pull Request resolved: #100749
SherlockNoMad

Differential Revision: D45620400

fbshipit-source-id: 82fafda359febdf9246f63a1355e376ecf17d5cb
@github-actions github-actions bot deleted the bahuang/reland_symin branch August 2, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants