#8714 Improve Error Messages for module re-assignment #9212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jramseyer
requested review from
apaszke,
colesbury,
ezyang,
gchanan and
soumith
as code owners
Contributor
Author
|
My mistake; I'll fix the lint errors! |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@jramseyer has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Jul 8, 2018
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
…#9212) Summary: Here's an improved error message. Let me know if this change makes the errors a little clearer. Closes pytorch#9212 Reviewed By: soumith Differential Revision: D8752896 Pulled By: jramseyer fbshipit-source-id: d2bd8462c3ddf14acd3de56a4c1aeb75a9bc4067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8714
Here's an improved error message. Let me know if this change makes the errors a little clearer.