Add sym_size/stride/numel/storage_offset to native_function.yaml #91919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
github-actions
bot
requested review from
Chillee,
albanD,
antoniojkim,
bdhirsh,
ezyang,
jbschlosser,
miladm,
voznesenskym and
wconstab
SherlockNoMad
requested review from
Chillee and
suo
and removed request for
Chillee,
albanD,
antoniojkim,
bdhirsh,
jbschlosser,
miladm,
voznesenskym and
wconstab
SherlockNoMad
commented
Jan 9, 2023
bdhirsh
reviewed
Jan 12, 2023
| device_check: NoCheck | ||
| device_guard: False | ||
|
|
||
| - func: sym_size.int(Tensor self, int dim) -> SymInt |
Contributor
There was a problem hiding this comment.
Is the main reason for adding these to native_functions so that we can add (canonical)? Or is there anything else.
Nit: this will also expose these under the torch namespace, torch.sym_size. Do we want that? (If not, there’s a way to hide it; I think there’s a dent list of ops hiding in gen_python_functions.py)
Contributor
Author
There was a problem hiding this comment.
My intention for adding them is to mark them as canonical, and publish a schema for these ops.
I actually don't know if it matters for torchgen to work for these ops, as they already have special handling in python_variable.py.
Yes, I don't need to expose them as torch.sym_size, I just need them available as torch.ops.aten.sym_size.
Contributor
Author
There was a problem hiding this comment.
But I am not able to make the CI happy...
I run into compiling problems for generated header files: https://gist.github.com/SherlockNoMad/19e9d618c22f57cc2d7eaf6700079fd0
…n.yaml" [ghstack-poisoned]
…n.yaml" [ghstack-poisoned]
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchbot revert -m "Break internal build" -c ghfirst |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
Collaborator
|
@SherlockNoMad your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Jan 17, 2023
…aml (#91919)" This reverts commit 0388400. Reverted #91919 on behalf of https://github.com/atalman due to Break internal build
SherlockNoMad
added a commit
that referenced
this pull request
Jan 18, 2023
SherlockNoMad
added a commit
that referenced
this pull request
Jan 27, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: f0ea5a7e60b2293ac11b3d4fcc88337c36f2ba08
SherlockNoMad
added a commit
that referenced
this pull request
Jan 31, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 1, 2023
…yaml (#91… (#92402) Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Approved by: https://github.com/ezyang
…n.yaml" [ghstack-poisoned]
SherlockNoMad
added a commit
that referenced
this pull request
May 5, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
SherlockNoMad
added a commit
that referenced
this pull request
May 8, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
SherlockNoMad
added a commit
that referenced
this pull request
May 9, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
pytorchmergebot
pushed a commit
that referenced
this pull request
May 10, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
pytorchmergebot
pushed a commit
that referenced
this pull request
May 11, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
pytorchmergebot
pushed a commit
that referenced
this pull request
May 12, 2023
…yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492
pytorchmergebot
pushed a commit
that referenced
this pull request
May 12, 2023
#100749) …yaml (#91… (#91919) Summary: Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Reviewed By: ezyang Differential Revision: D42565586 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492 Fixes #ISSUE_NUMBER Pull Request resolved: #100749 Approved by: https://github.com/zhxchen17, https://github.com/albanD
SherlockNoMad
added a commit
that referenced
this pull request
Jun 6, 2023
#91919) Summary: …yaml (https://github.com/pytorch/pytorch/issues/91… (#91919) Pull Request resolved: #91919 Approved by: https://github.com/ezyang Fixes #ISSUE_NUMBER Pull Request resolved: #92402 Pulled By: SherlockNoMad fbshipit-source-id: 1c2986e45307e076d239836a1b45441a9fa3c9d9 ghstack-source-id: 969f492 Fixes #ISSUE_NUMBER cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire Pull Request resolved: #100749 SherlockNoMad Differential Revision: D45620400 fbshipit-source-id: 82fafda359febdf9246f63a1355e376ecf17d5cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):