Replaces const ref with && for apply #9175
Conversation
marymcbreen
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
marymcbreen
force-pushed
the
marymcbreen-patch-1
branch
from
f55ced6 to
843ee9a
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@marymcbreen has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
torch/csrc/autograd/engine.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/autograd/function.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
marymcbreen
force-pushed
the
marymcbreen-patch-1
branch
from
843ee9a to
dc8a69a
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@marymcbreen has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
marymcbreen
force-pushed
the
marymcbreen-patch-1
branch
2 times, most recently
from
586479d to
9b061b7
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@marymcbreen has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
marymcbreen
force-pushed
the
marymcbreen-patch-1
branch
from
9b061b7 to
a0e7714
Compare
|
Sorry for the churn on this. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@marymcbreen has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
left a comment
zdevito
left a comment
There was a problem hiding this comment.
This looks good! I spot checked the places where move was added and didn't see any cases where the inputs were used after the move. A few minor formatting things and it is good to go.
torch/csrc/autograd/engine.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
torch/csrc/autograd/engine.cpp
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
marymcbreen
force-pushed
the
marymcbreen-patch-1
branch
from
a0e7714 to
a320f48
Compare
|
Updated for formatting. |
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@marymcbreen has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
marymcbreen
force-pushed
the
marymcbreen-patch-1
branch
from
a320f48 to
5dbed6f
Compare
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zdevito has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: Addresses pytorch#5011 Tested with python test/test_autograd.py Pull Request resolved: pytorch#9175 Reviewed By: zdevito Differential Revision: D8736377 Pulled By: marymcbreen fbshipit-source-id: ff86f427f7b2cf0cab5912e7f32812bd0f49a712
5 participants
Addresses #5011
Tested with python test/test_autograd.py