Fix conda install on distributions with strict POSIX sh #91371

ezyang · 2022-12-24T07:09:26Z

Stack from ghstack (oldest at bottom):

-> Fix conda install on distributions with strict POSIX sh #91371

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91371

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 8a925e0:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 38cc3d1 Pull Request resolved: #91371

ezyang · 2022-12-26T02:37:26Z

@pytorchbot merge -f "the rest of the problems look like preexisting conditions"

pytorchmergebot · 2022-12-26T02:38:59Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

kit1980 · 2022-12-27T19:26:19Z

trunk / cuda11.6-py3.10-gcc7-sm86 / test (slow, 1, 2, linux.g5.4xlarge.nvidia.gpu) started to fail after this PR with

Run documentation examples through mypy. ... FAIL (7.171s)
  test_doc_examples (__main__.TestTypeHints)
Run documentation examples through mypy. ...     test_doc_examples failed - num_retries_left: 3
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/test_type_hints.py", line 134, in test_doc_examples
    self.fail(f"mypy failed:\n{stderr}\n{stdout}")
AssertionError: mypy failed:
torch/distributed/fsdp/fully_sharded_data_parallel.py:870:5: error: Parenthesized context managers are only supported in Python 3.9 and greater  [syntax]
Found 1 error in 1 file (errors prevented further checking)

https://github.com/pytorch/pytorch/actions/runs/3778643918/jobs/6423437935

But I don't see how this PR can be possibly related...

kit1980 · 2022-12-27T19:50:04Z

@pytorchbot revert -m "trunk / cuda11.6-py3.10-gcc7-sm86 / test (slow, 1, 2, linux.g5.4xlarge.nvidia.gpu) started to fail after this PR with mypy error" -c ignoredsignal

pytorchmergebot · 2022-12-27T19:51:49Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2022-12-27T19:52:04Z

@ezyang your PR has been successfully reverted.

…)" This reverts commit 57dcd93. Reverted #91371 on behalf of https://github.com/kit1980 due to trunk / cuda11.6-py3.10-gcc7-sm86 / test (slow, 1, 2, linux.g5.4xlarge.nvidia.gpu) started to fail after this PR with mypy error

kit1980 · 2022-12-27T22:40:32Z

I still don't understand what's going on, but with the revert of this PR "trunk / cuda11.6-py3.10-gcc7-sm86 / test (slow, 1, 2, linux.g5.4xlarge.nvidia.gpu)" passed.
Maybe this PR makes it so a different Conda environment used compared to what's expected?

kit1980 · 2022-12-28T00:09:12Z

Let's try again after #91410

kit1980 · 2022-12-28T00:19:01Z

@pytorchbot rebase

pytorchmergebot · 2022-12-28T00:21:16Z

@pytorchbot successfully started a rebase job. Check the current status here

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

pytorchmergebot · 2022-12-28T00:21:34Z

Successfully rebased gh/ezyang/1678/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/91371)

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 9a39ea1 Pull Request resolved: #91371

kit1980 · 2022-12-28T00:23:24Z

@pytorchbot merge -f "Fix docker builds"

pytorchmergebot · 2022-12-28T00:24:56Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#91371 Approved by: https://github.com/albanD

We require the same fix that was made on upstream pytorch pytorch/pytorch#91371 ROCm/pytorch@b72ec7c Without this change install_conda.sh stage fails ``` #21 6.254 CondaFileIOError: '/opt/conda/pkgs/envs/*/env.txt'. [Errno 2] No such file or directory: '/opt/conda/pkgs/envs/*/env.txt' #21 6.254 #21 ERROR: executor failed running [/bin/sh -c bash ./install_conda.sh && rm install_conda.sh]: exit code: 1 ------ > [conda 2/3] RUN bash ./install_conda.sh && rm install_conda.sh: ------ executor failed running [/bin/sh -c bash ./install_conda.sh && rm install_conda.sh]: exit code: 1 ``` Locally tested with the `/builder/libtorch/build_docker.sh`

The issue was first solved in [/pull/91371] for CI/CD, but the main Dockerfile in the repo root still has this issue for people trying to test build custom image manually. Without it the build fails at installing miniconda ``` #14 3.802 Preparing transaction: ...working... done #14 4.087 Executing transaction: ...working... done #14 5.713 /root/miniconda.sh: 438: /root/miniconda.sh: [[: not found #14 5.713 #14 5.713 Installing * environment... #14 5.713 #14 5.714 /root/miniconda.sh: 444: /root/miniconda.sh: [[: not found #14 6.050 #14 6.050 CondaFileIOError: '/opt/conda/pkgs/envs/*/env.txt'. [Errno 2] No such file or directory: '/opt/conda/pkgs/envs/*/env.txt' #14 6.050 ``` With the modification, locally tested build successfully with `make -f ./docker.Makefile` as instructed in the README Pull Request resolved: #92702 Approved by: https://github.com/seemethere, https://github.com/malfet

Fix conda install on distributions with strict POSIX sh

eede6b1

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]

ezyang requested a review from jeffdaily as a code owner December 24, 2022 07:09

pytorch-bot bot added the topic: not user facing topic category label Dec 24, 2022

ezyang added a commit that referenced this pull request Dec 24, 2022

Fix conda install on distributions with strict POSIX sh

fe269c3

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 38cc3d1 Pull Request resolved: #91371

github-actions bot requested review from Chillee, SherlockNoMad, albanD, antoniojkim, bdhirsh, jbschlosser, miladm, voznesenskym and wconstab December 24, 2022 07:09

ezyang added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request labels Dec 24, 2022

ezyang requested a review from malfet December 24, 2022 07:14

ezyang mentioned this pull request Dec 24, 2022

Enable xdoctest runner in CI for real this time #83816

Closed

albanD approved these changes Dec 25, 2022

View reviewed changes

pytorchmergebot added the Merged label Dec 26, 2022

pytorchmergebot closed this in 57dcd93 Dec 26, 2022

pytorchmergebot added the Reverted label Dec 27, 2022

kit1980 mentioned this pull request Dec 27, 2022

[FSDP][Easy] Fix context manager syntax #91410

Closed

kit1980 reopened this Dec 28, 2022

github-actions bot requested a review from albanD December 28, 2022 00:09

Update on "Fix conda install on distributions with strict POSIX sh"

8a925e0

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]

pytorchmergebot pushed a commit that referenced this pull request Dec 28, 2022

Fix conda install on distributions with strict POSIX sh

e428437

See also conda/conda#10431 Signed-off-by: Edward Z. Yang <ezyangfb.com> ghstack-source-id: 9a39ea1 Pull Request resolved: #91371

pytorchmergebot closed this in ca39c5b Dec 28, 2022

ptrblck mentioned this pull request Jan 7, 2023

add sm_90 to CUDA11.8 builds pytorch/builder#1263

Merged

jataylo mentioned this pull request Jan 18, 2023

Fix conda install on distributions with strict POSIX sh ROCm/builder#18

Merged

VRShard mentioned this pull request Jan 20, 2023

Fix Dockerfile conda install error for some shells #92702

Closed

facebook-github-bot deleted the gh/ezyang/1678/head branch June 8, 2023 16:41

Fix conda install on distributions with strict POSIX sh #91371

Fix conda install on distributions with strict POSIX sh #91371

Uh oh!

Conversation

ezyang commented Dec 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 24, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91371

❌ 2 Failures

Uh oh!

ezyang commented Dec 26, 2022

Uh oh!

pytorchmergebot commented Dec 26, 2022

Merge started

Uh oh!

kit1980 commented Dec 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kit1980 commented Dec 27, 2022

Uh oh!

pytorchmergebot commented Dec 27, 2022

Uh oh!

pytorchmergebot commented Dec 27, 2022

Uh oh!

kit1980 commented Dec 27, 2022

Uh oh!

kit1980 commented Dec 28, 2022

Uh oh!

kit1980 commented Dec 28, 2022

Uh oh!

pytorchmergebot commented Dec 28, 2022

Uh oh!

pytorchmergebot commented Dec 28, 2022

Uh oh!

kit1980 commented Dec 28, 2022

Uh oh!

pytorchmergebot commented Dec 28, 2022

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ezyang commented Dec 24, 2022 •

edited

Loading

pytorch-bot bot commented Dec 24, 2022 •

edited

Loading

kit1980 commented Dec 27, 2022 •

edited

Loading