[CUDA12] Clean up deprecated APIs#91050
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/91050
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 89cf697: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D41469051 |
There was a problem hiding this comment.
This one is pretty much cosmetic (because I was working on the endif stuff similar to #90897). But I'm curious if we will end up in double definition since it's two independent if. So just add it here
There was a problem hiding this comment.
aten/src/ATen/cuda/CUDAGraph.cpp
Outdated
There was a problem hiding this comment.
ah ok I wasn't aware of #91118. In this case let's land that one
|
This pull request was exported from Phabricator. Differential Revision: D41469051 |
a72be93 to
f6c6ccc
Compare
Summary: Pull Request resolved: pytorch#91050 Some APIs are deprecated in newer version of CUDA. * cudaGraphInstantiate: From: ``` cudaGraphInstantiate ( cudaGraphExec_t* pGraphExec, cudaGraph_t graph, cudaGraphNode_t* pErrorNode, char* pLogBuffer, size_t bufferSize ) ``` To ``` __host__cudaError_t cudaGraphInstantiate ( cudaGraphExec_t* pGraphExec, cudaGraph_t graph, unsigned long long flags = 0 ) ``` * cudaProfilerInitialize: deprecated in cuda 11 and removed in cuda 12 Test Plan: GH CI Reviewed By: jianyuh Differential Revision: D41469051 fbshipit-source-id: b4e856717fc48672e7af5d2baba7931a31273c6d
f6c6ccc to
89cf697
Compare
|
This pull request was exported from Phabricator. Differential Revision: D41469051 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
See pytorch#91122 Summary: Some APIs are deprecated in newer version of CUDA. * cudaGraphInstantiate: From: ``` cudaGraphInstantiate ( cudaGraphExec_t* pGraphExec, cudaGraph_t graph, cudaGraphNode_t* pErrorNode, char* pLogBuffer, size_t bufferSize ) ``` To ``` __host__cudaError_t cudaGraphInstantiate ( cudaGraphExec_t* pGraphExec, cudaGraph_t graph, unsigned long long flags = 0 ) ``` * cudaProfilerInitialize: deprecated in cuda 11 and removed in cuda 12 Test Plan: GH CI Differential Revision: D41469051 Pull Request resolved: pytorch#91050 Approved by: https://github.com/jianyuh
…, backport to release/1.13 (#1233) * Update cuSPARSE usage for CUDA 12.0 (pytorch#90765) cuSPARSE v12.0 has started to use const pointers for the descriptors, from `cusparse.h` (documentation is incorrect): ```cpp typedef struct cusparseSpVecDescr const* cusparseConstSpVecDescr_t; typedef struct cusparseDnVecDescr const* cusparseConstDnVecDescr_t; typedef struct cusparseSpMatDescr const* cusparseConstSpMatDescr_t; typedef struct cusparseDnMatDescr const* cusparseConstDnMatDescr_t; ``` Changing also the function signature for the corresponding destructors to accept a const pointer. This PR adds `ConstCuSparseDescriptorDeleter` working with `cusparseStatus_t (*destructor)(const T*)`. Some algorithm enums were deprecated during CUDA 11 and removed in CUDA 12, I replaced the following occurences ``` CUSPARSE_CSRMM_ALG1 -> CUSPARSE_SPMM_CSR_ALG1 CUSPARSE_COOMM_ALG1 -> CUSPARSE_SPMM_COO_ALG1 CUSPARSE_COOMM_ALG2 -> CUSPARSE_SPMM_COO_ALG2 ``` Pull Request resolved: pytorch#90765 Approved by: https://github.com/cpuhrsch * [CUDA 12] Fix the endif guard position for cusparse const descriptors (pytorch#90897) [CUDA 12] Fix the endif guard position for cusparse const descriptors Related pytorch#90765 Pull Request resolved: pytorch#90897 Approved by: https://github.com/IvanYashchuk * [CUDA12] Clean up deprecated APIs (pytorch#91050) See pytorch#91122 Summary: Some APIs are deprecated in newer version of CUDA. * cudaGraphInstantiate: From: ``` cudaGraphInstantiate ( cudaGraphExec_t* pGraphExec, cudaGraph_t graph, cudaGraphNode_t* pErrorNode, char* pLogBuffer, size_t bufferSize ) ``` To ``` __host__cudaError_t cudaGraphInstantiate ( cudaGraphExec_t* pGraphExec, cudaGraph_t graph, unsigned long long flags = 0 ) ``` * cudaProfilerInitialize: deprecated in cuda 11 and removed in cuda 12 Test Plan: GH CI Differential Revision: D41469051 Pull Request resolved: pytorch#91050 Approved by: https://github.com/jianyuh * conditionally enable hipsparse const descriptors for version >= 2.4.0 (#1217) * conditionally enable hipsparse const descriptors * update hipsparse const API version condition to 2.4.0 --------- Co-authored-by: Ivan Yashchuk <[email protected]> Co-authored-by: Xiao Wang <[email protected]> Co-authored-by: Xiaodong Wang <[email protected]>
See #91122
Summary:
Some APIs are deprecated in newer version of CUDA.
From:
To
Test Plan: GH CI
Differential Revision: D41469051