Skip to content

[Fix]: remove unnecessary copies in aten, c10, and torch bindings #90629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Skylion007 wants to merge 4 commits into from
Closed

[Fix]: remove unnecessary copies in aten, c10, and torch bindings #90629

Skylion007 wants to merge 4 commits into from

Conversation

@Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Dec 10, 2022 •
edited
Loading

Applies various automated fixes that reduces the number of spurious copies in torch, aten, and c10. I also inlined any default dtors that would have made the type trivially destructible.

Follow up to #89000

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @EikanWang

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 10, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/90629

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 9ef6c42:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Dec 10, 2022
@github-actions github-actions bot added module: cpu CPU specific problem (e.g., perf, algorithm) NNC labels Dec 10, 2022
@Skylion007 Skylion007 marked this pull request as ready for review December 11, 2022 16:47
@Skylion007
Copy link
Collaborator Author

Skylion007 commented Dec 11, 2022

Also ccing @ezyang since a lot of these accidental copies are of SymInts / SymFloats.

ezyang
ezyang approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you consider helping us setup a lint for this? Only way to keep it fixed.

@ezyang
Copy link
Contributor

ezyang commented Dec 12, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 12, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 12, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@Skylion007
Copy link
Collaborator Author

Skylion007 commented Dec 12, 2022

Would you consider helping us setup a lint for this? Only way to keep it fixed.

I would love to but that would require closing #62011. These checks are already linted under places where lintrunner's clang-tidy is currently run, but that's a small fraction of the code base.

@Skylion007 Skylion007 mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@robieta robieta Awaiting requested review from robieta

@BowenBao BowenBao Awaiting requested review from BowenBao

@abock abock Awaiting requested review from abock

@albanD albanD Awaiting requested review from albanD

@soulitzer soulitzer Awaiting requested review from soulitzer

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) NNC open source release notes: jit release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Skylion007 @ezyang @pytorchmergebot @pytorchbot