Refactor batch sampler #8958
Closed
Refactor batch sampler #8958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitriy-serdyuk
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
@pytorchbot retest this please |
soumith
approved these changes
Jun 27, 2018
|
This change makes train_dataset = \
datasets.MNIST('../data', train=True, download=True,
transform=transforms.Compose([
transforms.ToTensor(),
transforms.Normalize((0.1307,), (0.3081,))
]))
train_loader = torch.utils.data.DataLoader(train_dataset,
batch_size=args.batch_size, sampler=torch.utils.data.distributed.DistributedSampler(train_dataset, num_replicas=1, rank=0), **kwargs)The reason seems to be that it creates a lot of tensors for each index element. I was able to make it fast again by adding the cast to int. |
Member
|
Thanks for the message @alsrgv ! indices = torch.randperm(len(self.dataset), generator=g).tolist()as Can you send a PR fixing this? |
|
Fixes it for me! |
alsrgv
pushed a commit
to alsrgv/pytorch
that referenced
this pull request
Aug 8, 2018
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2018
Summary: Pull Request resolved: #10361 Differential Revision: D9240798 Pulled By: ezyang fbshipit-source-id: dc4cfe79612f711bbcff34a147877df6a5f7b89f
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Aug 10, 2018
Summary: Pull Request resolved: pytorch#10361 Differential Revision: D9240798 Pulled By: ezyang fbshipit-source-id: dc4cfe79612f711bbcff34a147877df6a5f7b89f
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#10361 Differential Revision: D9240798 Pulled By: ezyang fbshipit-source-id: dc4cfe79612f711bbcff34a147877df6a5f7b89f
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 22, 2018
Summary: Since #8958 was merged, the BatchSampler samples 0d tensors from WeightedRandomSampler instead of integers. It significantly reduces performance. This PR fix it the same way as #10361 fix DistributedSampler. Pull Request resolved: #10636 Differential Revision: D9423869 Pulled By: zou3519 fbshipit-source-id: f94da2d4cccf70e63beea6cfc3d1230b5610ae44
PenghuiCheng
pushed a commit
to PenghuiCheng/pytorch
that referenced
this pull request
Sep 11, 2018
Summary: Since pytorch#8958 was merged, the BatchSampler samples 0d tensors from WeightedRandomSampler instead of integers. It significantly reduces performance. This PR fix it the same way as pytorch#10361 fix DistributedSampler. Pull Request resolved: pytorch#10636 Differential Revision: D9423869 Pulled By: zou3519 fbshipit-source-id: f94da2d4cccf70e63beea6cfc3d1230b5610ae44
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8652, fixes #8957