Skip to content

Fix cat striding in PrimTorch #89332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ezyang wants to merge 4 commits into from
Closed

Fix cat striding in PrimTorch #89332

ezyang wants to merge 4 commits into from

Conversation

@ezyang
Copy link
Contributor

@ezyang ezyang commented Nov 19, 2022 •
edited
Loading

Stack from ghstack (oldest at bottom):

Signed-off-by: Edward Z. Yang [email protected]

@ezyang
Fix cat striding in PrimTorch
9b39ce7 
Signed-off-by: Edward Z. Yang <[email protected]>

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/89332

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit f31bffb:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang added a commit that referenced this pull request Nov 19, 2022
@ezyang
Fix cat striding in PrimTorch
33fb532 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: a838936
Pull Request resolved: #89332
@ezyang
Update on "Fix cat striding in PrimTorch"
6fe3474 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang added release notes: composability release notes category topic: bug fixes topic category labels Nov 19, 2022
@ezyang
Copy link
Contributor Author

ezyang commented Nov 19, 2022

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 19, 2022
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / macos-12-py3-arm64-mps / Run MPS tests

Details for Dev Infra team Raised by workflow job

@ezyang ezyang mentioned this pull request Nov 19, 2022
Closed
@ezyang
Update on "Fix cat striding in PrimTorch"
ce63163 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang ezyang requested a review from kulinseth as a code owner November 19, 2022 21:18
@ezyang ezyang mentioned this pull request Nov 19, 2022
Closed
@ezyang
Copy link
Contributor Author

ezyang commented Nov 19, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@ezyang
Update on "Fix cat striding in PrimTorch"
f31bffb 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

[ghstack-poisoned]
@ezyang
Copy link
Contributor Author

ezyang commented Nov 20, 2022

@pytorchbot merge

ezyang added a commit that referenced this pull request Nov 20, 2022
@ezyang
Fix cat striding in PrimTorch
d9e877d 
Signed-off-by: Edward Z. Yang <ezyangfb.com>

ghstack-source-id: cb45528
Pull Request resolved: #89332
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor Author

ezyang commented Nov 20, 2022

@pytorchbot merge -f "flaky ci only"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 20, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@ezyang @kulinseth
Fix cat striding in PrimTorch (pytorch#89332)
53d30fd 
Signed-off-by: Edward Z. Yang <[email protected]>
Pull Request resolved: pytorch#89332
Approved by: https://github.com/ngimel
@facebook-github-bot facebook-github-bot deleted the gh/ezyang/1544/head branch June 8, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@albanD albanD Awaiting requested review from albanD

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@bdhirsh bdhirsh Awaiting requested review from bdhirsh

@Chillee Chillee Awaiting requested review from Chillee

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

@voznesenskym voznesenskym Awaiting requested review from voznesenskym

@wconstab wconstab Awaiting requested review from wconstab

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: composability release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ezyang @pytorchmergebot @ngimel