Skip to content

Update lr_scheduler.pyi to match lr_scheduler.py#88818

Closed
janeyx99 wants to merge 1 commit intomasterfrom
change-pyi-too
Closed

Update lr_scheduler.pyi to match lr_scheduler.py#88818
janeyx99 wants to merge 1 commit intomasterfrom
change-pyi-too

Conversation

@janeyx99
Copy link
Copy Markdown
Contributor

@janeyx99 janeyx99 commented Nov 10, 2022 •
edited by pytorch-bot bot
Loading

Following #88503, we should also update the pyi file

cc @albanD @mruberry @jbschlosser @walterddr @kshitij12345 @saketh-are

@janeyx99 janeyx99 requested a review from soulitzer November 10, 2022 16:16
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 10, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88818

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2c8643e:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@janeyx99 janeyx99 added module: nn Related to torch.nn topic: improvements topic category labels Nov 10, 2022
@janeyx99 janeyx99 marked this pull request as ready for review November 10, 2022 17:41
@janeyx99 janeyx99 requested a review from albanD as a code owner November 10, 2022 17:41
@janeyx99 janeyx99 added accept2ship release notes: nn release notes category and removed module: nn Related to torch.nn labels Nov 10, 2022
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 10, 2022

This PR has been accepted with the accept2ship label. Attempting to merge now.

@pytorchbot merge -l

@pytorch-bot pytorch-bot bot added ciflow/trunk Trigger trunk jobs on your pull request and removed accept2ship labels Nov 10, 2022
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 10, 2022

Merge started

The -l land checks flag is deprecated and no longer needed. Instead we now automatically add the ciflow\trunk label to your PR once it's approved

Your change will be merged once all checks on your PR pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 10, 2022

Merge failed

Reason: The following mandatory check(s) failed (Rule superuser):

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Copy Markdown
Contributor Author

janeyx99 commented Nov 11, 2022

@pytorchmergebot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 11, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@janeyx99 @kulinseth
Update lr_scheduler.pyi to match lr_scheduler.py (pytorch#88818)
e47272f 
Following pytorch#88503, we should also update the pyi file

Pull Request resolved: pytorch#88818
Approved by: https://github.com/soulitzer
@github-actions github-actions bot deleted the change-pyi-too branch May 12, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soulitzer soulitzer soulitzer approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: improvements topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janeyx99 @pytorchmergebot @soulitzer