[MPS] Add Unique and unique_consecutive ops. #88532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytorch-bot
bot
added
ciflow/mps
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88532
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 14944cc: FLAKY - The following jobs failed but were likely due to flakiness present on master:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
ngimel
added
the
triaged
Collaborator
Author
|
@malfet , rebased . Please give it a review. |
Contributor
|
/easycla |
malfet
approved these changes
Nov 21, 2022
Contributor
There was a problem hiding this comment.
Looks good to me.
Major areas of concern:
- Large tensors (add overflow checks when computing number of elements)
- For the CPU fallbacks, aren't results needed to be copied back to MPS?
Nits:
- Formatting:
if ()block should always be surrounded by{and don't one needs spaces after objc argument name? - std::array vs NSArray (this way one can avoid
[NSNull null])
Collaborator
Author
|
/easycla |
Collaborator
|
@pytorchbot merge -g |
Collaborator
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
I'm building this branch myself, and I get this warning an awful lot: on my macos 13.2 M1. I'm building the usual recommended pytorch way: |
Collaborator
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
Collaborator
|
@pytorchbot merge -f "Lint+MPS is green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
Add check for macos 13.0
Collaborator
|
@pytorchbot merge -g |
Collaborator
Merge startedYour change will be merged once all checks on your PR pass since you used the green (-g) flag (ETA: 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-focal-rocm5.3-py3.8 / test (default, 2, 2, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
Collaborator
|
@pytorchbot merge -f "Lint+MPS is green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
|
@jkoudys this change should get into the next pytorch nightly binary - could you please try that and let me know if you see any issues? |
|
Is this merged on master? It looks like it is, but I am unable to use the op in yolov5 and pytorch 1.13.1, and I have tested on the nightly too. |
Collaborator
|
@tj-safely nightly builds should have them. Can you try doing a force reinstall to make sure it got installed properly? |
|
@DenisVieriu97 I have tried a few different methods for installing a matching torchvision package to no success. Right now I have this: And get this error message: When I add torchvision to your command or try with only torchvision, it attempts to install many different versions of torchvision and does not install any of them. Finally, I have this torchvision version installed by running this command: which I found from this link: Thank you for your help and further guidance is appreciated. |
Collaborator
|
@tj-safely try uninstalling all previous packages of torch/torchvision/torchaudio, then do a clean install. then: |
|
I am still unable to install torchvision this way. To reproduce:
Everything works successfully until the last command: |
Collaborator
|
@tj-safely could you please try installing only torchvision and torch? |
This worked. For some reason mps is sometimes slower than cpu on yolov5, but I do not get exceptions anymore. Thank you so much for you help! |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 1, 2024
And use convenient methods TODO was added by an accidental copy-n-paste of code from #82315 into #88532 Pull Request resolved: #118902 Approved by: https://github.com/kit1980
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
And use convenient methods TODO was added by an accidental copy-n-paste of code from #82315 into #88532 Pull Request resolved: #118902 Approved by: https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check for macos 13.0
Fixes #88487