reland "Do not use unsafe restriding for subclasses (#87610)" #88343

bdhirsh · 2022-11-02T18:22:10Z

Stack from ghstack (oldest at bottom):

This reverts commit 5b75b19.

This reverts commit 5b75b19. [ghstack-poisoned]

pytorch-bot · 2022-11-02T18:22:13Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88343

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 80f0d71:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…"" This reverts commit 5b75b19. [ghstack-poisoned]

bdhirsh · 2022-11-04T17:08:39Z

@pytorchbot merge

bdhirsh · 2022-11-04T18:50:24Z

@pytorchbot merge

pytorchmergebot · 2022-11-04T18:57:35Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-11-04T19:22:50Z

Merge failed

Reason: 2 additional jobs have failed, first few of them are: trunk ,trunk / linux-bionic-cuda11.7-py3.10-gcc7 / test (functorch, 1, 1, linux.4xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

…"" This reverts commit 5b75b19. [ghstack-poisoned]

bdhirsh · 2022-11-07T15:09:26Z

@pytorchbot merge -f "flaky tests: OOM, couldnt communicate with Nvidia driver"

pytorchmergebot · 2022-11-07T15:11:10Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-11-07T15:11:16Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x ad5c124614d398191d02c92651f871132d52fc69 returned non-zero exit code 1

Auto-merging test/test_functionalization.py
CONFLICT (content): Merge conflict in test/test_functionalization.py
error: could not apply ad5c124614... reland "Do not use unsafe restriding for subclasses (#87610)"
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

…"" This reverts commit 5b75b19. [ghstack-poisoned]

bdhirsh · 2022-11-11T17:33:11Z

@pytorchbot merge

pytorchmergebot · 2022-11-11T17:35:07Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2022-11-11T17:35:11Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 85d565f32dc854a8ae1b29e98ecf8f1487005374 returned non-zero exit code 1

Auto-merging test/functorch/test_aotdispatch.py
CONFLICT (content): Merge conflict in test/functorch/test_aotdispatch.py
error: could not apply 85d565f32d... reland "Do not use unsafe restriding for subclasses (#87610)"
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Details for Dev Infra team

Raised by workflow job

…"" This reverts commit 5b75b19. [ghstack-poisoned]

bdhirsh · 2022-11-14T13:41:06Z

@pytorchbot merge

pytorchmergebot · 2022-11-14T13:42:48Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…ytorch#88343) This reverts commit 5b75b19. Pull Request resolved: pytorch#88343 Approved by: https://github.com/ezyang

reland "Do not use unsafe restriding for subclasses (#87610)"

038b1bb

This reverts commit 5b75b19. [ghstack-poisoned]

bdhirsh mentioned this pull request Nov 2, 2022

reland "fix as_strided_scatter_backward (#87646)" #88342

Closed

This was referenced Nov 2, 2022

dont clone symints, dont clobber symint proxies #88230

Closed

misc symintifying fixes #88197

Closed

Update functionalization metadata more eagerly. *_scatter ops should preserve input stride/storage_offset #88198

Closed

github-actions bot requested review from Chillee, albanD, anjali411, antoniojkim, ezyang, miladm and wconstab November 2, 2022 18:22

ezyang approved these changes Nov 2, 2022

View reviewed changes

albanD removed their request for review November 2, 2022 19:14

bdhirsh added the release notes: composability release notes category label Nov 3, 2022

Update on "reland "Do not use unsafe restriding for subclasses (#87610)…

383b90b

…"" This reverts commit 5b75b19. [ghstack-poisoned]

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 4, 2022

Update on "reland "Do not use unsafe restriding for subclasses (#87610)…

a64c5b0

…"" This reverts commit 5b75b19. [ghstack-poisoned]

bdhirsh added 3 commits November 7, 2022 10:01

Update on "reland "Do not use unsafe restriding for subclasses (#87610)…

42c053c

…"" This reverts commit 5b75b19. [ghstack-poisoned]

Update on "reland "Do not use unsafe restriding for subclasses (#87610)…

f7bd665

…"" This reverts commit 5b75b19. [ghstack-poisoned]

Update on "reland "Do not use unsafe restriding for subclasses (#87610)…

6bb1dcf

…"" This reverts commit 5b75b19. [ghstack-poisoned]

Update on "reland "Do not use unsafe restriding for subclasses (#87610)…

80f0d71

…"" This reverts commit 5b75b19. [ghstack-poisoned]

pytorchmergebot added the Merged label Nov 14, 2022

pytorchmergebot closed this in ec4eada Nov 14, 2022

facebook-github-bot deleted the gh/bdhirsh/341/head branch June 8, 2023 15:43

reland "Do not use unsafe restriding for subclasses (#87610)" #88343

reland "Do not use unsafe restriding for subclasses (#87610)" #88343

Uh oh!

Conversation

bdhirsh commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Nov 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88343

✅ No Failures

Uh oh!

bdhirsh commented Nov 4, 2022

Uh oh!

bdhirsh commented Nov 4, 2022

Uh oh!

pytorchmergebot commented Nov 4, 2022

Merge started

Uh oh!

pytorchmergebot commented Nov 4, 2022

Merge failed

Uh oh!

bdhirsh commented Nov 7, 2022

Uh oh!

pytorchmergebot commented Nov 7, 2022

Merge started

Uh oh!

pytorchmergebot commented Nov 7, 2022

Merge failed

Uh oh!

bdhirsh commented Nov 11, 2022

Uh oh!

pytorchmergebot commented Nov 11, 2022

Merge started

Uh oh!

pytorchmergebot commented Nov 11, 2022

Merge failed

Uh oh!

bdhirsh commented Nov 14, 2022

Uh oh!

pytorchmergebot commented Nov 14, 2022

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bdhirsh commented Nov 2, 2022 •

edited

Loading

pytorch-bot bot commented Nov 2, 2022 •

edited

Loading