Put Python Dispatcher cache in dict, clear it on new registrations. #88329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation is that I am going to add the ability to temporarily install entries to the python dispatcher, and to do that, I need an easier way to clear the cache. Putting the cache in a dict centralizes cache clearing in one place. I then add some easy cache clearing. Signed-off-by: Edward Z. Yang <[email protected]> [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/88329
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 9264ad5: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
github-actions
bot
requested review from
Chillee,
Krovatkin,
anjali411,
antoniojkim,
bdhirsh,
miladm and
wconstab
ezyang
added
release notes: composability
…trations." The motivation is that I am going to add the ability to temporarily install entries to the python dispatcher, and to do that, I need an easier way to clear the cache. Putting the cache in a dict centralizes cache clearing in one place. I then add some easy cache clearing. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
…trations." The motivation is that I am going to add the ability to temporarily install entries to the python dispatcher, and to do that, I need an easier way to clear the cache. Putting the cache in a dict centralizes cache clearing in one place. I then add some easy cache clearing. Signed-off-by: Edward Z. Yang <ezyangfb.com> [ghstack-poisoned]
Contributor
|
@pytorchbot revert -m "test_decomp takes an extra 2 hours in some jobs, windows takes so long it times out" -c weird |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
Collaborator
|
@ezyang your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Nov 3, 2022
…tions. (#88329)" This reverts commit 86c7cd2. Reverted #88329 on behalf of https://github.com/clee2000 due to test_decomp takes an extra 2 hours in some jobs, windows takes so long it times out
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 4, 2022
…registrations. (#88329)"" (#88489) The bug was that I was accidentally caching at the wrong key name, so we were never actually hitting the cache. I've renamed the resolved key to final_key to avoid shadowing in this way. This reverts commit 410ce96. Pull Request resolved: #88489 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…ytorch#88329) The motivation is that I am going to add the ability to temporarily install entries to the python dispatcher, and to do that, I need an easier way to clear the cache. Putting the cache in a dict centralizes cache clearing in one place. I then add some easy cache clearing. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#88329 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…tions. (pytorch#88329)" This reverts commit 86c7cd2. Reverted pytorch#88329 on behalf of https://github.com/clee2000 due to test_decomp takes an extra 2 hours in some jobs, windows takes so long it times out
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
…registrations. (pytorch#88329)"" (pytorch#88489) The bug was that I was accidentally caching at the wrong key name, so we were never actually hitting the cache. I've renamed the resolved key to final_key to avoid shadowing in this way. This reverts commit 410ce96. Pull Request resolved: pytorch#88489 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…ytorch#88329) The motivation is that I am going to add the ability to temporarily install entries to the python dispatcher, and to do that, I need an easier way to clear the cache. Putting the cache in a dict centralizes cache clearing in one place. I then add some easy cache clearing. Signed-off-by: Edward Z. Yang <[email protected]> Pull Request resolved: pytorch#88329 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…tions. (pytorch#88329)" This reverts commit 86c7cd2. Reverted pytorch#88329 on behalf of https://github.com/clee2000 due to test_decomp takes an extra 2 hours in some jobs, windows takes so long it times out
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
…registrations. (pytorch#88329)"" (pytorch#88489) The bug was that I was accidentally caching at the wrong key name, so we were never actually hitting the cache. I've renamed the resolved key to final_key to avoid shadowing in this way. This reverts commit 410ce96. Pull Request resolved: pytorch#88489 Approved by: https://github.com/albanD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The motivation is that I am going to add the ability to temporarily
install entries to the python dispatcher, and to do that, I need
an easier way to clear the cache. Putting the cache in a dict
centralizes cache clearing in one place. I then add some easy
cache clearing.
Signed-off-by: Edward Z. Yang [email protected]