Skip to content

use nv_diag_suppress #87712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
r-barnes wants to merge 1 commit into from
Closed

use nv_diag_suppress #87712

r-barnes wants to merge 1 commit into from

Conversation

@r-barnes
Copy link
Contributor

@r-barnes r-barnes commented Oct 25, 2022 •
edited by pytorch-bot bot
Loading

Fixes:

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/cuda/UnaryFractionKernels.cu(125): warning #20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/cuda/UnaryFractionKernels.cu(125): warning #20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/sparse/cuda/SparseMatMul.cu(73): warning #20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/sparse/cuda/SparseMatMul.cu(73): warning #20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

cc @ngimel

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 25, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87712

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c870452:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: sparse release notes category label Oct 25, 2022
@r-barnes r-barnes force-pushed the richard/use_nv_diag_suppress branch from 30bd2cc to c870452 Compare October 25, 2022 17:42
@r-barnes r-barnes added module: cuda Related to torch.cuda, and CUDA support in general module: build warnings Related to warnings during build process release notes: cuda release notes category release notes: build release notes category topic: deprecation topic category topic: build labels Oct 25, 2022
@r-barnes r-barnes requested a review from ngimel October 26, 2022 00:04
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 26, 2022
@r-barnes
Copy link
Contributor Author

r-barnes commented Oct 27, 2022

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Oct 27, 2022

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@r-barnes @kulinseth
use nv_diag_suppress (pytorch#87712)
b5eccd4 
Fixes:
```
/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/cuda/UnaryFractionKernels.cu(125): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/cuda/UnaryFractionKernels.cu(125): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/sparse/cuda/SparseMatMul.cu(73): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/sparse/cuda/SparseMatMul.cu(73): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead
```

cc @ngimel
Pull Request resolved: pytorch#87712
Approved by: https://github.com/soumith
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@r-barnes @kulinseth
use nv_diag_suppress (pytorch#87712)
fb5b100 
Fixes:
```
/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/cuda/UnaryFractionKernels.cu(125): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/cuda/UnaryFractionKernels.cu(125): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/sparse/cuda/SparseMatMul.cu(73): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead

/dev/shm/rbarnes/tempfs/pytorch/aten/src/ATen/native/sparse/cuda/SparseMatMul.cu(73): warning pytorch#20236-D: pragma "diag_suppress" is deprecated, use "nv_diag_suppress" instead
```

cc @ngimel
Pull Request resolved: pytorch#87712
Approved by: https://github.com/soumith
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel Awaiting requested review from ngimel

1 more reviewer

@soumith soumith soumith approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: build warnings Related to warnings during build process module: cuda Related to torch.cuda, and CUDA support in general release notes: build release notes category release notes: cuda release notes category release notes: sparse release notes category topic: build topic: deprecation topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@r-barnes @pytorchmergebot @soumith