Skip to content

aot_dispatch test fix: always use functionalization in symbolic tests #87647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bdhirsh wants to merge 10 commits into from
Closed

aot_dispatch test fix: always use functionalization in symbolic tests #87647

bdhirsh wants to merge 10 commits into from

Conversation

@bdhirsh
Copy link
Contributor

@bdhirsh bdhirsh commented Oct 24, 2022 •
edited
Loading

@bdhirsh bdhirsh mentioned this pull request Oct 24, 2022
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87647

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures

As of commit 762dad4:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@bdhirsh bdhirsh mentioned this pull request Oct 24, 2022
Closed
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 24, 2022
@bdhirsh bdhirsh mentioned this pull request Oct 24, 2022
Closed
bdhirsh added a commit that referenced this pull request Oct 24, 2022
@bdhirsh
aot_dispatch test fix: always use functionalization in symbolic tests
9d13163 
ghstack-source-id: 06f64d1
Pull Request resolved: #87647
@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 24, 2022
@ezyang
Copy link
Contributor

ezyang commented Oct 31, 2022

Any update on this? Definitely want this in master

@ezyang
Copy link
Contributor

ezyang commented Oct 31, 2022

This is a blocker for #88063 ; https://github.com/pytorch/pytorch/pull/88063/files#diff-a15aae4cf23da44970db7cece62ff981265575c798c62f7b52d87c8809dfe2e1 reproduces the workaround from symbolic shapes branch

@ezyang ezyang mentioned this pull request Nov 1, 2022
Closed
This was referenced Nov 1, 2022
Closed
Closed
@bdhirsh
Copy link
Contributor Author

bdhirsh commented Nov 1, 2022

Updated - I just added the extra xfails in this PR to unblock, I have fixes higher up in the stack

@bdhirsh bdhirsh mentioned this pull request Nov 1, 2022
Closed
@bdhirsh
Copy link
Contributor Author

bdhirsh commented Nov 2, 2022

@pytorchbot merge -f "flaky scribe uploading error"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 2, 2022

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Nov 5, 2022
@bdhirsh @kulinseth
aot_dispatch test fix: always use functionalization in symbolic tests (…
183bdc2 
…pytorch#87647)

Pull Request resolved: pytorch#87647
Approved by: https://github.com/ezyang, https://github.com/Chillee
kulinseth pushed a commit to kulinseth/pytorch that referenced this pull request Dec 10, 2022
@bdhirsh @kulinseth
aot_dispatch test fix: always use functionalization in symbolic tests (…
ec95d9f 
…pytorch#87647)

Pull Request resolved: pytorch#87647
Approved by: https://github.com/ezyang, https://github.com/Chillee
@facebook-github-bot facebook-github-bot deleted the gh/bdhirsh/333/head branch June 8, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezyang ezyang ezyang approved these changes

@Chillee Chillee Chillee approved these changes

@albanD albanD Awaiting requested review from albanD

@anjali411 anjali411 Awaiting requested review from anjali411

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@Krovatkin Krovatkin Awaiting requested review from Krovatkin

@miladm miladm Awaiting requested review from miladm

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bdhirsh @ezyang @pytorchmergebot @Chillee