fix as_strided_scatter_backward #87646
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87646
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 FailuresAs of commit 874f298: The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 24, 2022
albanD
approved these changes
Oct 24, 2022
Collaborator
albanD
left a comment
albanD
left a comment
There was a problem hiding this comment.
Great catch!
Also I guess this means we don't have opinfo (and thus autograd testing) for these ops... We should add them!
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. [ghstack-poisoned]
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. [ghstack-poisoned]
Contributor
Author
|
we had a few skipped's OpInfo's for |
github-actions
bot
requested review from
Krovatkin,
albanD,
anjali411,
antoniojkim,
ezyang,
miladm and
wconstab
albanD
approved these changes
Oct 24, 2022
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. [ghstack-poisoned]
bdhirsh
added
topic: bug fixes
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. cc albanD [ghstack-poisoned]
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. Fixes #88105 cc albanD [ghstack-poisoned]
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. Fixes #88105 cc albanD [ghstack-poisoned]
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. Fixes #88105 cc albanD [ghstack-poisoned]
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. Fixes #88105 cc albanD [ghstack-poisoned]
Collaborator
|
If this goes in after https://github.com/pytorch/pytorch/pull/85583/files then it should review the skips on the OpInfo |
Contributor
|
@pytorchbot revert -m 'Sorry for reverting your PR but I think this one or one of the PR in the stack break bionic-cuda11.7 on trunk https://hud.pytorch.org/pytorch/pytorch/commit/70782981f06a042796d4604df2ec1491f4f5b194' -c nosignal |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
Collaborator
|
@bdhirsh your PR has been successfully reverted. |
pytorchmergebot
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit f9d7985. Reverted #87646 on behalf of https://github.com/huydhn due to Sorry for reverting your PR but I think this one or one of the PR in the stack break bionic-cuda11.7 on trunk https://hud.pytorch.org/pytorch/pytorch/commit/70782981f06a042796d4604df2ec1491f4f5b194
bdhirsh
added a commit
that referenced
this pull request
Nov 2, 2022
This reverts commit 71fb763. [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 3, 2022
This reverts commit 71fb763. [ghstack-poisoned]
bdhirsh
added a commit
that referenced
this pull request
Nov 4, 2022
This reverts commit 71fb763. [ghstack-poisoned]
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. Fixes pytorch#88105 Pull Request resolved: pytorch#87646 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Nov 5, 2022
This reverts commit f9d7985. Reverted pytorch#87646 on behalf of https://github.com/huydhn due to Sorry for reverting your PR but I think this one or one of the PR in the stack break bionic-cuda11.7 on trunk https://hud.pytorch.org/pytorch/pytorch/commit/70782981f06a042796d4604df2ec1491f4f5b194
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 7, 2022
This reverts commit 71fb763. Pull Request resolved: #88342 Approved by: https://github.com/zou3519
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory. Fixes pytorch#88105 Pull Request resolved: pytorch#87646 Approved by: https://github.com/albanD
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This reverts commit f9d7985. Reverted pytorch#87646 on behalf of https://github.com/huydhn due to Sorry for reverting your PR but I think this one or one of the PR in the stack break bionic-cuda11.7 on trunk https://hud.pytorch.org/pytorch/pytorch/commit/70782981f06a042796d4604df2ec1491f4f5b194
kulinseth
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Dec 10, 2022
This reverts commit 71fb763. Pull Request resolved: pytorch#88342 Approved by: https://github.com/zou3519
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as_strided_scatter's derivative formula was broken - instead of making a "mask" of 1's and 0's, it would effectively make a mask of 1's and uninitialized memory.
Fixes #88105
Stack from ghstack (oldest at bottom):
cc @albanD