Delete torch::deploy from pytorch core (#85953) (#85953) #87454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with pytorch#85443 which is where the review history can be found. Pull Request resolved: pytorch#85953 Approved by: https://github.com/seemethere, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/936e93058b2781d6cee2da59cccba051726dd46f Reviewed By: seemethere Differential Revision: D40167063 Pulled By: seemethere fbshipit-source-id: 62e8843a8d69e67c8ec77a2d0db87539516cc904
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/87454
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 34be342: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there.
This PR was created due to syncing issues with #85443 which is where the review history can be found.
Pull Request resolved: #85953 Approved by: https://github.com/seemethere, https://github.com/malfet
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/936e93058b2781d6cee2da59cccba051726dd46f
Reviewed By: seemethere
Differential Revision: D40167063
Pulled By: seemethere
fbshipit-source-id: 62e8843a8d69e67c8ec77a2d0db87539516cc904