Delete Torch::deploy from pytorch #85443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85443
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 3 PendingAs of commit 9ab9df9: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39710545 |
PaliC
force-pushed
the
export-D39710545
branch
from
e69e9ae to
69380cf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39710545 |
PaliC
force-pushed
the
export-D39710545
branch
from
69380cf to
d6d3b52
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39710545 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39710545 |
PaliC
force-pushed
the
export-D39710545
branch
from
d6d3b52 to
b9ca90e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39710545 |
PaliC
force-pushed
the
export-D39710545
branch
from
b9ca90e to
392ec98
Compare
PaliC
force-pushed
the
export-D39710545
branch
from
392ec98 to
97e941d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39710545 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39710545 |
PaliC
force-pushed
the
export-D39710545
branch
from
97e941d to
464074a
Compare
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: 168867021 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: 168867021 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! ghstack-source-id: 168867021 Pull Request resolved: #85945
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
Pull Request resolved: #85945 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: 168867021 ghstack-source-id: 168867021 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
Pull Request resolved: #85953 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: 168867021 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)! [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Sep 30, 2022
Pull Request resolved: #85953 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: 169004332 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
PaliC
added a commit
that referenced
this pull request
Oct 3, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 3, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 3, 2022
Pull Request resolved: #85953 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: d4bf19f Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
PaliC
added a commit
that referenced
this pull request
Oct 5, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 5, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 5, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 5, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 5, 2022
Pull Request resolved: #85953 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: b5ef016 Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
PaliC
added a commit
that referenced
this pull request
Oct 6, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 6, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. [ghstack-poisoned]
PaliC
added a commit
that referenced
this pull request
Oct 6, 2022
Pull Request resolved: #85953 As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. ghstack-source-id: a40f71b Differential Revision: [D39933787](https://our.internmc.facebook.com/intern/diff/D39933787/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D39933787/)!
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 6, 2022
As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Pull Request resolved: #85953 Approved by: https://github.com/seemethere, https://github.com/malfet
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Summary: As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Pull Request resolved: #85953 Approved by: https://github.com/seemethere, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/936e93058b2781d6cee2da59cccba051726dd46f Reviewed By: seemethere Differential Revision: D40167063 Pulled By: seemethere fbshipit-source-id: 62e8843a8d69e67c8ec77a2d0db87539516cc904
atalman
pushed a commit
to atalman/pytorch
that referenced
this pull request
Oct 21, 2022
Summary: As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with pytorch#85443 which is where the review history can be found. Pull Request resolved: pytorch#85953 Approved by: https://github.com/seemethere, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/936e93058b2781d6cee2da59cccba051726dd46f Reviewed By: seemethere Differential Revision: D40167063 Pulled By: seemethere fbshipit-source-id: 62e8843a8d69e67c8ec77a2d0db87539516cc904
malfet
pushed a commit
that referenced
this pull request
Oct 21, 2022
Summary: As we have migrated torch::deploy over to https://github.com/pytorch/multipy, we can now delete it from pytorch core as ongoing development will happen there. This PR was created due to syncing issues with #85443 which is where the review history can be found. Pull Request resolved: #85953 Approved by: https://github.com/seemethere, https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/936e93058b2781d6cee2da59cccba051726dd46f Reviewed By: seemethere Differential Revision: D40167063 Pulled By: seemethere fbshipit-source-id: 62e8843a8d69e67c8ec77a2d0db87539516cc904 Co-authored-by: Sahan Paliskara (Meta Employee) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Removes torch::deploy from pytorch core. The new home of torch::deploy can be found at https://github.com/pytorch/multipy.
Test Plan: This shouldn't break anything hopefully. Currently all internal users are migrated to multipy/runtime.