Revisit python tracing OD flow #85326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

slgong-fb wants to merge 1 commit into pytorch:master from slgong-fb:export-D39647074

Contributor

slgong-fb commented Sep 20, 2022

Summary:

add set_withstack(), overriding ClientInterface's no-op funtion.
revert start() and #ifdef

Differential Revision: D39647074

slgong-fb requested a review from robieta as a code owner

September 20, 2022 07:37

pytorch-bot bot commented Sep 20, 2022 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85326

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures, 1 Pending

As of commit 5bc946d:

The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added cla signed fb-exported labels

Contributor

facebook-github-bot commented Sep 20, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

slgong-fb added a commit to slgong-fb/pytorch that referenced this pull request


          Revisit python tracing OD flow (pytorch#85326)

e50d41e

Summary:
Pull Request resolved: pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Differential Revision: D39647074

fbshipit-source-id: a9c93013553daf23deaaedd633421b8d85dd2020

slgong-fb force-pushed the export-D39647074 branch from 9069653 to e50d41e Compare

September 20, 2022 07:48

Contributor

facebook-github-bot commented Sep 20, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

slgong-fb added ciflow/trunk ciflow/periodic labels

slgong-fb added a commit to slgong-fb/kineto that referenced this pull request


          Revisit python tracing OD flow (#85326)

51571c1

Summary:
X-link: pytorch/pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Differential Revision: D39647074

fbshipit-source-id: 01a5df79a775c34d6b8e6047ab5cf6c018271fb0

slgong-fb mentioned this pull request

Revisit python tracing OD flow (#85326) pytorch/kineto#658

Closed

slgong-fb requested review from aaronenyeshi and chaekit

September 22, 2022 18:08

Contributor

facebook-github-bot commented Sep 22, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

slgong-fb force-pushed the export-D39647074 branch from e50d41e to 742abd3 Compare

September 22, 2022 23:08

slgong-fb added a commit to slgong-fb/kineto that referenced this pull request


          Revisit python tracing OD flow (pytorch#658)

Summary:
Pull Request resolved: pytorch#658

X-link: pytorch/pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Differential Revision: D39647074

fbshipit-source-id: e0dbe987d704e9276e0cfcf85f01e8a614a0758d

slgong-fb added a commit to slgong-fb/pytorch that referenced this pull request


          Revisit python tracing OD flow (pytorch#658)

3ff6953

Summary:
X-link: pytorch/kineto#658

Pull Request resolved: pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Test Plan:
- launch a python test case with the following command for on-demand flow:
echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf

Differential Revision: D39647074

fbshipit-source-id: a28ed2a9a981fd5cebb674e882d7f37738b3afa0

slgong-fb force-pushed the export-D39647074 branch from 742abd3 to 3ff6953 Compare

September 22, 2022 23:22

Contributor

facebook-github-bot commented Sep 22, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

1 similar comment

Contributor

facebook-github-bot commented Sep 23, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

slgong-fb force-pushed the export-D39647074 branch from 3ff6953 to 259e73c Compare

September 23, 2022 19:06

slgong-fb added a commit to slgong-fb/pytorch that referenced this pull request


          Revisit python tracing OD flow (pytorch#658)

259e73c

Summary:
X-link: pytorch/kineto#658

Pull Request resolved: pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Test Plan:
- launch a python test case with the following command for on-demand flow:
echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf

Differential Revision: D39647074

fbshipit-source-id: 44f38aeb4a6f80d3c69202e3a74ddbb6dacb8cd9

slgong-fb added a commit to slgong-fb/kineto that referenced this pull request


          Revisit python tracing OD flow (pytorch#658)

2dac1c2

Summary:
Pull Request resolved: pytorch#658

X-link: pytorch/pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Differential Revision: D39647074

fbshipit-source-id: 4a5d0f3cd5e35ed177954c409932e86bcd417496

slgong-fb force-pushed the export-D39647074 branch from 259e73c to 14e07b0 Compare

September 23, 2022 23:52

Contributor

facebook-github-bot commented Sep 23, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

slgong-fb added a commit to slgong-fb/pytorch that referenced this pull request


          Revisit python tracing OD flow (pytorch#658)

14e07b0

Summary:
X-link: pytorch/kineto#658

Pull Request resolved: pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Test Plan:
- launch a python test case with the following command for on-demand flow:
echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf

Differential Revision: D39647074

fbshipit-source-id: 7c19fad6e101a2e35e372a8b1a11122e84a17697

slgong-fb added a commit to slgong-fb/kineto that referenced this pull request


          Revisit python tracing OD flow (pytorch#658)

85dbe93

Summary:
Pull Request resolved: pytorch#658

X-link: pytorch/pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Reviewed By: chaekit

Differential Revision: D39647074

fbshipit-source-id: 44477570462e6144ff45b959434ff0f578f792c2

Contributor

facebook-github-bot commented Sep 27, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

slgong-fb force-pushed the export-D39647074 branch from 14e07b0 to 22dd957 Compare

September 27, 2022 00:38

chaekit approved these changes

View reviewed changes

Contributor

facebook-github-bot commented Sep 27, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

slgong-fb force-pushed the export-D39647074 branch from 22dd957 to c9b65d2 Compare

September 27, 2022 01:33

slgong-fb added a commit to slgong-fb/kineto that referenced this pull request


          Revisit python tracing OD flow (pytorch#658)

cd94b9f

Summary:
Pull Request resolved: pytorch#658

X-link: pytorch/pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Reviewed By: chaekit

Differential Revision: D39647074

fbshipit-source-id: 8e5ad5d53fb9c1f8d701f3773f329fe60db531f8


          Revisit python tracing OD flow (pytorch#658)

5bc946d

Summary:
X-link: pytorch/kineto#658

Pull Request resolved: pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Test Plan:
- launch a python test case with the following command for on-demand flow:
echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf

Reviewed By: chaekit

Differential Revision: D39647074

fbshipit-source-id: b00cbbb642217844fa200cda0465de04e205383c

slgong-fb force-pushed the export-D39647074 branch from c9b65d2 to 5bc946d Compare

September 27, 2022 05:39

Contributor

facebook-github-bot commented Sep 27, 2022

This pull request was exported from Phabricator. Differential Revision: D39647074

facebook-github-bot pushed a commit to pytorch/kineto that referenced this pull request


          Revisit python tracing OD flow (#658)

bbbf8d5

Summary:
Pull Request resolved: #658

X-link: pytorch/pytorch#85326

- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Reviewed By: chaekit

Differential Revision: D39647074

fbshipit-source-id: a3e6968c184aef2ef0e77334ef7ad950455fd77f

Contributor Author

slgong-fb commented Sep 27, 2022

@pytorchbot merge -f 'flaky test failed. this diff has passed all tests before rebase'

Collaborator

pytorchmergebot commented Sep 27, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the force (-f) flag. This means your change will be merged immediately, bypassing any CI checks (ETA: 1-5 minutes). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

Collaborator

pytorchmergebot commented Sep 27, 2022

Merge failed

Reason: This PR has internal changes and must be landed via Phabricator

Details for Dev Infra team

Raised by workflow job

Contributor

facebook-github-bot commented Sep 27, 2022

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

Collaborator

pytorchmergebot commented Sep 27, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

pytorchmergebot added the Merged label

pytorchmergebot closed this in

16543f6

Contributor

github-actions bot commented Sep 27, 2022

Hey @slgong-fb.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

drisspg pushed a commit to drisspg/pytorch that referenced this pull request


          Revisit python tracing OD flow (pytorch#85326)

Summary:
- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Differential Revision: D39647074

Pull Request resolved: pytorch#85326
Approved by: https://github.com/chaekit

mehtanirav pushed a commit that referenced this pull request


          Revisit python tracing OD flow (#85326)

be2109a

Summary:
- add `set_withstack()`, overriding `ClientInterface`'s no-op funtion.
- revert `start()` and #ifdef

Differential Revision: D39647074

Pull Request resolved: #85326
Approved by: https://github.com/chaekit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/periodic ciflow/trunk cla signed fb-exported Merged