-
Notifications
You must be signed in to change notification settings - Fork 26.3k
Use angle brackets in include for internal clangtidy #85032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/85032
Note: Links to docs will display an error until the docs builds have been completed. ✅ No Failures, 3 PendingAs of commit 255dcbd: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
huydhn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here and land check progress here. |
Merge failedReason: Failed to merge; some land checks failed: pull, pull / linux-bionic-cuda11_6-py3_10-gcc7-deploy / build If you believe this is an error, you can use the old behavior with Please reach out to the PyTorch DevX Team with feedback or questions! Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot rebase |
|
@pytorchbot successfully started a rebase job. Check the current status here |
This issue was found after importing #70978 into fbsource.
|
Successfully rebased |
54eb99f to
255dcbd
Compare
|
@kit1980 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
|
@pytorchbot successfully started a merge job. Check the current status here and land check progress here. |
This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn
This issue was found after importing #70978 into fbsource. Pull Request resolved: #85032 Approved by: https://github.com/huydhn
This issue was found after importing #70978 into fbsource.