Skip to content

Add variable_list support to ExtractVariables struct#84583

Closed
steventk-g wants to merge 1 commit intopytorch:masterfrom
steventk-g:extract-variable-list
Closed

Add variable_list support to ExtractVariables struct#84583
steventk-g wants to merge 1 commit intopytorch:masterfrom
steventk-g:extract-variable-list

Conversation

@steventk-g
Copy link
Copy Markdown
Contributor

@steventk-g steventk-g commented Sep 6, 2022 •
edited by soulitzer
Loading

This is required to unblock pytorch/xla#3843, which lowers the einsum op for pytorch/xla. Because one method input parameter is a TensorList, we need to support TensorLists here so that we can support einsum gradients.

For release notes (bc-breaking):

  • Prior to this change, c++ custom autograd Function considers tensors passed in TensorList to not be tensors for the purposes of recording the backward graph. After this change, custom Functions that receive TensorList must modify their backward functions to also compute gradients for these additional tensor inputs. Note that this behavior now differs from that of autograd custom Functions in Python.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Sep 6, 2022 •
edited
Loading

🔗 Helpful links

✅ No Failures (0 Pending)

As of commit 27d5165f1e (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

@steventk-g steventk-g mentioned this pull request Sep 6, 2022
Merged
@steventk-g steventk-g force-pushed the extract-variable-list branch from 27d5165 to 3c32913 Compare September 7, 2022 20:55
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Sep 7, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/84583

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit ed1fc2f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@steventk-g steventk-g force-pushed the extract-variable-list branch from 3c32913 to a32c386 Compare September 14, 2022 03:33
@steventk-g steventk-g marked this pull request as ready for review September 14, 2022 15:48
@steventk-g steventk-g force-pushed the extract-variable-list branch 3 times, most recently from 0611d11 to 1da0b77 Compare September 14, 2022 16:03
bdhirsh
bdhirsh reviewed Sep 14, 2022
View reviewed changes
@soulitzer
Copy link
Copy Markdown
Contributor

soulitzer commented Sep 15, 2022

Could we add a test for this here?
https://github.com/pytorch/pytorch/blob/master/test/cpp/api/autograd.cpp

@steventk-g steventk-g force-pushed the extract-variable-list branch from 1da0b77 to fd402a7 Compare September 15, 2022 04:01
@steventk-g
Copy link
Copy Markdown
Contributor Author

steventk-g commented Sep 15, 2022

Could we add a test for this here? https://github.com/pytorch/pytorch/blob/master/test/cpp/api/autograd.cpp

Done

@steventk-g steventk-g force-pushed the extract-variable-list branch from fd402a7 to b021758 Compare September 15, 2022 04:19
@steventk-g steventk-g force-pushed the extract-variable-list branch from b021758 to ed1fc2f Compare September 15, 2022 18:06
@JackCaoG
Copy link
Copy Markdown
Collaborator

JackCaoG commented Sep 16, 2022 •
edited
Loading

@soulitzer Can we get another round of review? :D

soulitzer
soulitzer approved these changes Sep 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@soulitzer soulitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soulitzer
Copy link
Copy Markdown
Contributor

soulitzer commented Sep 16, 2022

@pytorchbot merge -g

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Sep 16, 2022

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered with the green (-g) flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 16, 2022

Hey @steventk-g.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

@soulitzer soulitzer added release notes: autograd release notes category topic: bc breaking topic category labels Sep 16, 2022
mehtanirav pushed a commit that referenced this pull request Oct 4, 2022
@steventk-g @mehtanirav
Add variable_list support to ExtractVariables struct (#84583)
67c327c 
This is required to unblock pytorch/xla#3843, which lowers the einsum op for pytorch/xla.  Because one method input parameter is a TensorList, we need to support TensorLists here so that we can support einsum gradients.
Pull Request resolved: #84583
Approved by: https://github.com/soulitzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdhirsh bdhirsh bdhirsh left review comments

@JackCaoG JackCaoG JackCaoG left review comments

@soulitzer soulitzer soulitzer approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

cla signed Merged open source release notes: autograd release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@steventk-g @facebook-github-bot @soulitzer @JackCaoG @pytorchmergebot @bdhirsh @pytorchbot