[JIT] End-to-end example-based robustness testing for hybrid frontend #8451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesr66a
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
jamesr66a
changed the title
8 tasks
apaszke
approved these changes
Jun 14, 2018
Contributor
apaszke
left a comment
apaszke
left a comment
There was a problem hiding this comment.
LGTM. Some code is unnecessary and could be removed.
test/test_jit.py
Outdated
| init.orthogonal_(self.conv4.weight) | ||
|
|
||
| net = Net(upscale_factor=4) | ||
| net._initialize_weights() |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
test/test_jit.py
Outdated
| self.affine2 = nn.Linear(128, 2) | ||
|
|
||
| self.saved_log_probs = [] | ||
| self.rewards = [] |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
|
@pytorchbot retest this please |
1 similar comment
Contributor
|
@pytorchbot retest this please |
Collaborator
Author
|
@zdevito i think that one fusion test was indeed flaky; i don't see the failure anymore. I'm going to go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put these in
test_jitfor two reason:These tests revealed many issues, which I've created issues for and will shortly create a meta-issue to track.