Skip to content

Conversation

@seravee
Copy link
Contributor

@seravee seravee commented Jun 13, 2018

Adding NCHW2NHWC and NHWC2NCHW to nomnigraph. This is for int8 efforts.

@onnxbot onnxbot added the caffe2 label Jun 13, 2018
Copy link
Contributor

@yinghai yinghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seravee
Copy link
Contributor Author

seravee commented Jun 14, 2018

Already landed on internal FB so closing this repo for now.

@seravee seravee closed this Jun 14, 2018
@yinghai yinghai reopened this Jun 14, 2018
@yinghai
Copy link
Contributor

yinghai commented Jun 14, 2018

Actually landing on both repos is recommended as it helps reduce the sync load on oncall.

@seravee
Copy link
Contributor Author

seravee commented Jun 14, 2018

Oh I see, cool!

@seravee
Copy link
Contributor Author

seravee commented Jun 14, 2018

@pytorchbot retest this please

1 similar comment
@seravee
Copy link
Contributor Author

seravee commented Jun 14, 2018

@pytorchbot retest this please

@seravee
Copy link
Contributor Author

seravee commented Jun 15, 2018

Not very sure what is going on as pytorch bot pass all tests yesterday and now it failed mkl build.

Consider the test it failed is for net_async test and this PR is only on nomnigraph, I guess this means the failure is unrelated??

@ezyang
Copy link
Contributor

ezyang commented Jun 15, 2018

Test is known flaky, ignore it.

@yinghai yinghai merged commit ec23ee6 into pytorch:master Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants