Skip to content

[MPS][BE] Use same convenience dispatch method #82982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 1 commit into from
Closed

[MPS][BE] Use same convenience dispatch method #82982

malfet wants to merge 1 commit into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 8, 2022

Apply feedback suggested to handle_tensor_tensor_binary_op to handle_tensor_scalar_binary_op as well

@malfet
[MPS][BE] Use same convenience dispatch method
621cad7 
Apply feedback suggested to `handle_tensor_tensor_binary_op` to `handle_tensor_scalar_binary_op` as well
@malfet malfet requested a review from a team August 8, 2022 15:54
@malfet malfet requested a review from kulinseth as a code owner August 8, 2022 15:54
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 8, 2022 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/82982

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures, 1 Pending

As of commit 621cad7:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request and removed cla signed labels Aug 8, 2022
@malfet malfet mentioned this pull request Aug 8, 2022
Closed
@malfet
Copy link
Contributor Author

malfet commented Aug 8, 2022

@pytorchbot merge -f "RunMPS is green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 8, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

Hey @malfet.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Aug 9, 2022
@malfet @facebook-github-bot
[MPS][BE] Use same convenience dispatch method (#82982) (#82982)
3fa6b4f 
Summary:
Apply feedback suggested to `handle_tensor_tensor_binary_op` to `handle_tensor_scalar_binary_op` as well

Pull Request resolved: #82982
Approved by: https://github.com/seemethere, https://github.com/albanD

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/6098a7c5a663e5dfaacb55628c74c7c909041d58

Reviewed By: seemethere

Differential Revision: D38542352

Pulled By: malfet

fbshipit-source-id: 91ef3eea8a97bf18253c781c080f0efd81d3973f
@github-actions github-actions bot deleted the malfet-patch-2 branch February 18, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seemethere seemethere seemethere approved these changes

@albanD albanD albanD approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@malfet @pytorchmergebot @seemethere @albanD @facebook-github-bot