Use multipy.package in multipy/runtime (#111)
#82690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This change points multipy::runtime to use multipy.package instead of torch.package by copying `_deploy.py` (which is used in order to pass objects in and out of interpreters) into multipy as well as making the neccessary changes to allow `multipy::runtime` to access `multipy.package` and `_deploy.py`. X-link: meta-pytorch/multipy#111 Reviewed By: d4l3k Differential Revision: D38337551 Pulled By: PaliC fbshipit-source-id: 44faa10a8b995b47f257d6fe20d9caa335237c9e
Contributor
🔗 Helpful links
✅ No Failures (7 Pending)As of commit fb7e715 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D38337551 |
d4l3k
approved these changes
Aug 3, 2022
Member
d4l3k
left a comment
d4l3k
left a comment
There was a problem hiding this comment.
sounds reasonable, just one nit
| def write_to_zip(file_path, strip_file_path, zf): | ||
| stripped_file_path = remove_prefix(file_path, strip_file_dir + "/") | ||
| def write_to_zip(file_path, strip_file_path, zf, prepend_str=""): | ||
| stripped_file_path = prepend_str + remove_prefix(file_path, strip_file_dir + "/") |
Member
There was a problem hiding this comment.
nit: prefix_path might be a better name for these instead of prepend_str
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
to meta-pytorch/multipy
that referenced
this pull request
Aug 3, 2022
Summary: X-link: pytorch/pytorch#82690 This change points multipy::runtime to use multipy.package instead of torch.package by copying `_deploy.py` (which is used in order to pass objects in and out of interpreters) into multipy as well as making the neccessary changes to allow `multipy::runtime` to access `multipy.package` and `_deploy.py`. Pull Request resolved: #111 Reviewed By: d4l3k Differential Revision: D38337551 Pulled By: PaliC fbshipit-source-id: dec35e0f07efa1c989f6356dd073dfddd12a186e
Contributor
|
Hey @PaliC. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 3, 2022
Summary: Pull Request resolved: #82690 This change points multipy::runtime to use multipy.package instead of torch.package by copying `_deploy.py` (which is used in order to pass objects in and out of interpreters) into multipy as well as making the neccessary changes to allow `multipy::runtime` to access `multipy.package` and `_deploy.py`. X-link: meta-pytorch/multipy#111 Reviewed By: d4l3k Differential Revision: D38337551 Pulled By: PaliC fbshipit-source-id: dec35e0f07efa1c989f6356dd073dfddd12a186e
anirbanr-fb-r2p
pushed a commit
to anirbanr-fb-r2p/multipy
that referenced
this pull request
Aug 11, 2022
Summary: X-link: pytorch/pytorch#82690 This change points multipy::runtime to use multipy.package instead of torch.package by copying `_deploy.py` (which is used in order to pass objects in and out of interpreters) into multipy as well as making the neccessary changes to allow `multipy::runtime` to access `multipy.package` and `_deploy.py`. Pull Request resolved: meta-pytorch#111 Reviewed By: d4l3k Differential Revision: D38337551 Pulled By: PaliC fbshipit-source-id: dec35e0f07efa1c989f6356dd073dfddd12a186e
anirbanr-fb-r2p
pushed a commit
to anirbanr-fb-r2p/multipy
that referenced
this pull request
Aug 11, 2022
Use multipy.package in `multipy/runtime` (#82690) Summary: X-link: pytorch/pytorch#82690 This change points multipy::runtime to use multipy.package instead of torch.package by copying `_deploy.py` (which is used in order to pass objects in and out of interpreters) into multipy as well as making the neccessary changes to allow `multipy::runtime` to access `multipy.package` and `_deploy.py`. Pull Request resolved: meta-pytorch#111 Reviewed By: d4l3k Differential Revision: D38337551 Pulled By: PaliC fbshipit-source-id: dec35e0f07efa1c989f6356dd073dfddd12a186e
anirbanr-fb-r2p
pushed a commit
to anirbanr-fb-r2p/multipy
that referenced
this pull request
Aug 11, 2022
Use multipy.package in `multipy/runtime` (#82690) Summary: X-link: pytorch/pytorch#82690 This change points multipy::runtime to use multipy.package instead of torch.package by copying `_deploy.py` (which is used in order to pass objects in and out of interpreters) into multipy as well as making the neccessary changes to allow `multipy::runtime` to access `multipy.package` and `_deploy.py`. Pull Request resolved: meta-pytorch#111 Reviewed By: d4l3k Differential Revision: D38337551 Pulled By: PaliC fbshipit-source-id: dec35e0f07efa1c989f6356dd073dfddd12a186e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change points multipy::runtime to use multipy.package instead of torch.package by copying
_deploy.py(which is used in order to pass objects in and out of interpreters) into multipy as well as making the neccessary changes to allowmultipy::runtimeto accessmultipy.packageand_deploy.py.X-link: meta-pytorch/multipy#111
Reviewed By: d4l3k
Differential Revision: D38337551
Pulled By: PaliC