Revert "reverted diff: Add python stack tracing option on on-demand flow" #82378

slgong-fb · 2022-07-27T23:31:08Z

Summary:
Changes:
add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf)
deliver PYTHON_STACK_TRACE value to kineto_client_interface start()
abstract class also changed.
Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit)
https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces

Test Plan:
launch a python test case with the following command for on-demand flow:
echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf

Reviewed By: chaekit

Differential Revision: D38220201

facebook-github-bot · 2022-07-27T23:31:14Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/82378
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit a2741ff (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

facebook-github-bot · 2022-07-27T23:31:34Z

This pull request was exported from Phabricator. Differential Revision: D38220201

slgong-fb · 2022-07-28T04:53:20Z

@chaekit @robieta Please review this PR.

robieta · 2022-08-08T18:20:11Z

torch/csrc/profiler/kineto_client_interface.cpp

You can't reuse USE_KINETO_UPDATED. If you want to go this route you have to define a new variable or switch it to a version counter.

This #ifdef is just a workround to pass CI tests (as FB internal diff contain changes on both pytorch and kineto). This #ifdef guard will be removed on submodule update.

Last time this workaround that has successfully worked as I heard failed for some reason... so I first retry this workaround. If this is failing again, I will refactor/rewrite my changes.

robieta · 2022-08-08T18:21:34Z

torch/csrc/profiler/kineto_client_interface.cpp

I don't see why this was needed. Can't you just add an entry?

There was a lint bug. This is just a workaround.

robieta · 2022-08-08T18:25:59Z

torch/csrc/profiler/kineto_client_interface.cpp

You can reduce the size of the #ifdef block:

#ifdef VERSION_GUARD_VAR void start(bool withStack) override { #else void start() override { bool withStack{false}; #endif

as mentioned above. this guard will be removed at the end.

facebook-github-bot · 2022-08-08T19:36:26Z

This pull request was exported from Phabricator. Differential Revision: D38220201

…low" (pytorch#82378) Summary: Pull Request resolved: pytorch#82378 Changes: add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf) deliver PYTHON_STACK_TRACE value to kineto_client_interface start() abstract class also changed. Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit) https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces Test Plan: launch a python test case with the following command for on-demand flow: echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf Reviewed By: chaekit Differential Revision: D38220201 fbshipit-source-id: 071b7158768cb16d253490d269ad0692f470f86c

…low" (#82378) Summary: X-link: pytorch/pytorch#82378 Changes: add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf) deliver PYTHON_STACK_TRACE value to kineto_client_interface start() abstract class also changed. Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit) https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces Reviewed By: chaekit Differential Revision: D38220201 fbshipit-source-id: e4224bd87aed9cf662dfd95bc63573c3415b5997

…low" (pytorch#645) Summary: X-link: pytorch/kineto#645 Pull Request resolved: pytorch#82378 Changes: add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf) deliver PYTHON_STACK_TRACE value to kineto_client_interface start() abstract class also changed. Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit) https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces Test Plan: launch a python test case with the following command for on-demand flow: echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf Reviewed By: chaekit Differential Revision: D38220201 fbshipit-source-id: 07d5d5263e6d470dd17acb04fe0c3e2d4439fd1c

facebook-github-bot · 2022-08-08T21:49:37Z

This pull request was exported from Phabricator. Differential Revision: D38220201

facebook-github-bot · 2022-08-15T18:12:49Z

This pull request was exported from Phabricator. Differential Revision: D38220201

facebook-github-bot · 2022-08-15T18:19:22Z

This pull request was exported from Phabricator. Differential Revision: D38220201

…low" (pytorch#645) Summary: X-link: pytorch/kineto#645 Pull Request resolved: pytorch#82378 Changes: add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf) deliver PYTHON_STACK_TRACE value to kineto_client_interface start() abstract class also changed. Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit) https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces Test Plan: launch a python test case with the following command for on-demand flow: echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf Reviewed By: chaekit Differential Revision: D38220201 fbshipit-source-id: dddbeed163af37b965e663b66dd92f030fdcba42

…low" (pytorch#645) Summary: Pull Request resolved: pytorch#645 X-link: pytorch/pytorch#82378 Changes: add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf) deliver PYTHON_STACK_TRACE value to kineto_client_interface start() abstract class also changed. Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit) https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces Reviewed By: chaekit Differential Revision: D38220201 fbshipit-source-id: 94937bbbf4db658d184334eb7a9393610fecfed9

facebook-github-bot · 2022-08-15T22:21:03Z

This pull request was exported from Phabricator. Differential Revision: D38220201

…low" (#645) Summary: Pull Request resolved: #645 X-link: pytorch/pytorch#82378 Changes: add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf) deliver PYTHON_STACK_TRACE value to kineto_client_interface start() abstract class also changed. Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit) https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces Reviewed By: chaekit Differential Revision: D38220201 fbshipit-source-id: 8cef92522e957c2e0bedd4ae33231171cc188fa2

facebook-github-bot · 2022-08-16T17:41:11Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-08-16T17:42:31Z

@pytorchbot successfully started a merge job. Check the current status here.
The merge job was triggered without a flag. This means that your change will be merged once all checks on your PR have passed (ETA: 0-4 Hours). If this is not the intended behavior, feel free to use some of the other merge options in the wiki.
Please reach out to the PyTorch DevX Team with feedback or questions!

facebook-github-bot · 2022-08-16T17:42:39Z

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot · 2022-08-16T17:44:06Z

Can't merge closed PR #82378

…low" (#645) Summary: X-link: pytorch/kineto#645 Pull Request resolved: #82378 Changes: add an option in Config; can use 'PYTHON_STACK_TRACE=true' option (via .conf) deliver PYTHON_STACK_TRACE value to kineto_client_interface start() abstract class also changed. Trace after changes by running //kineto/libkineto/fb/integration_tests/trace_tester.cpp (requested by chaekit) https://www.internalfb.com/intern/perfdoctor/trace_view?filepath=tree%2Ftraces%2Fdynocli%2F0%2F1657304871%2F127.0.0.1%2Flibkineto_activities_3502962.json.gz&bucket=gpu_traces Test Plan: launch a python test case with the following command for on-demand flow: echo -e "PYTHON_STACK_TRACE=true" > /tmp/scott_kineto.conf && dyno gputrace --gputrace_duration 300ms --gpuconf /tmp/scott_kineto.conf Reviewed By: chaekit Differential Revision: D38220201 fbshipit-source-id: 8cef92522e957c2e0bedd4ae33231171cc188fa2

github-actions · 2022-08-16T18:12:29Z

Hey @slgong-fb.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot added the cla signed label Jul 27, 2022

facebook-github-bot added the fb-exported label Jul 27, 2022

robieta requested review from chaekit and robieta July 28, 2022 23:20

robieta requested changes Aug 8, 2022

View reviewed changes

robieta added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Aug 8, 2022

slgong-fb force-pushed the export-D38220201 branch from f532729 to 0f42fd2 Compare August 8, 2022 19:36

slgong-fb mentioned this pull request Aug 8, 2022

Revert "reverted diff: Add python stack tracing option on on-demand flow" (#82378) pytorch/kineto#645

Closed

slgong-fb force-pushed the export-D38220201 branch from 0f42fd2 to a0d7776 Compare August 8, 2022 21:49

slgong-fb force-pushed the export-D38220201 branch from a0d7776 to dc40a7e Compare August 15, 2022 18:12

slgong-fb force-pushed the export-D38220201 branch from dc40a7e to 60f2243 Compare August 15, 2022 18:19

slgong-fb force-pushed the export-D38220201 branch from 60f2243 to a2741ff Compare August 15, 2022 22:21

chaekit approved these changes Aug 16, 2022

View reviewed changes

pytorchmergebot added the Merged label Aug 16, 2022

pytorchmergebot closed this in 6a5ca40 Aug 16, 2022

Revert "reverted diff: Add python stack tracing option on on-demand flow" #82378

Revert "reverted diff: Add python stack tracing option on on-demand flow" #82378

Uh oh!

Conversation

slgong-fb commented Jul 27, 2022

Uh oh!

facebook-github-bot commented Jul 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

facebook-github-bot commented Jul 27, 2022

Uh oh!

slgong-fb commented Jul 28, 2022

Uh oh!

robieta Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

slgong-fb Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

robieta Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

slgong-fb Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

robieta Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

slgong-fb Aug 8, 2022

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 8, 2022

Uh oh!

facebook-github-bot commented Aug 8, 2022

Uh oh!

facebook-github-bot commented Aug 15, 2022

Uh oh!

facebook-github-bot commented Aug 15, 2022

Uh oh!

facebook-github-bot commented Aug 15, 2022

Uh oh!

facebook-github-bot commented Aug 16, 2022

Uh oh!

pytorchmergebot commented Aug 16, 2022

Uh oh!

facebook-github-bot commented Aug 16, 2022

Uh oh!

pytorchmergebot commented Aug 16, 2022

Uh oh!

github-actions bot commented Aug 16, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

facebook-github-bot commented Jul 27, 2022 •

edited

Loading