Closed
Conversation
Thus avoiding `TypeError: 'float' object cannot be interpreted as an integer` when trying to create integer tensor from floating point values Use `c10::checked_convert` to detect overflows during tensor construction from scalars. Modify sparse_csr test that violated this rule Fixes #69319 Tested in #81233 Pull Request resolved: #81372 Approved by: https://github.com/ezyang, https://github.com/ngimel (cherry picked from commit 69d7334)
Second attempt of landing the change after #66530 Skip nan hashes comparison validation in `jit/test_hash.py`, as it behaves differently in 3.10 vs other pythons Skip tensor_fx assert tests Skip initializing uint8 tensors from negative values in `TestScript.test_torch_tensor_as_tensor` Final step in closing #66424 Pull Request resolved: #81233 Approved by: https://github.com/seemethere (cherry picked from commit 7ccf693)
facebook-github-bot
added
cla signed
oncall: jit
kit1980
approved these changes
Jul 27, 2022
Contributor
Author
|
@pytorchbot merge -f "[OTHER] This is just a reland" |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @malfet. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
Summary: This is a re-land of #81372 and #81233 with the exception that it does not force the range-checks on older Python runtime versions and as such should not affect the internal workloads, which were the reason for revert, see #81372 (comment) - [Py3.10] Allow floats to be imported as Long (#81372) - [CI] Move CUDA-11.6 to Python-3.10 configuration (#81233) - Don't do anything about range checks for pre-py3.10 Pull Request resolved: #82329 Approved by: https://github.com/kit1980 Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d80fe49de09399e77a384bd9573c7bb69887dd20 Reviewed By: osalpekar Differential Revision: D38234293 Pulled By: malfet fbshipit-source-id: 3f7ffe729ab2a3ef692bc95f5398dfdf395b2397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-land of #81372 and #81233 with the exception that it does not force the range-checks on older Python runtime versions and as such should not affect the internal workloads, which were the reason for revert, see #81372 (comment)