[MPS] Workaround for uint8 gather bug #82315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulinseth
approved these changes
Jul 27, 2022
Collaborator
kulinseth
left a comment
kulinseth
left a comment
There was a problem hiding this comment.
For now, its okay to have this workaround. But we need to investigate the generated Graph as to why uint8 data type is not support.
Contributor
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge and created land time checks. See merge status here and land check progress here |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 27, 2022
Looks like MPSGraph generates a wrong shader for expanding column into a matrix, though datatype should not really matter for scatter-gather ops, should it? Also, fix minor typo: `c10::ScalarType:Char` is signed type, whereas `c10::ScalarType::Byte` is unsigned. Workarounds #82305 by aliasing tensors of `uint8` types to `int8` typed ones Pull Request resolved: #82315 Approved by: https://github.com/janeyx99, https://github.com/kulinseth
Contributor
|
Hey @malfet. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
Summary: Looks like MPSGraph generates a wrong shader for expanding column into a matrix, though datatype should not really matter for scatter-gather ops, should it? Also, fix minor typo: `c10::ScalarType:Char` is signed type, whereas `c10::ScalarType::Byte` is unsigned. Workarounds #82305 by aliasing tensors of `uint8` types to `int8` typed ones Pull Request resolved: #82315 Approved by: https://github.com/janeyx99, https://github.com/kulinseth Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/47b03ad42e10b4bf6602c1d5bcb82079800e67b5 Reviewed By: osalpekar Differential Revision: D38234366 Pulled By: malfet fbshipit-source-id: 87b7652176c2e73c9e523995999e27e8e5a79381
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 1, 2024
And use convenient methods TODO was added by an accidental copy-n-paste of code from #82315 into #88532 Pull Request resolved: #118902 Approved by: https://github.com/kit1980
pytorch-bot bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
And use convenient methods TODO was added by an accidental copy-n-paste of code from #82315 into #88532 Pull Request resolved: #118902 Approved by: https://github.com/kit1980
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like MPSGraph generates a wrong shader for expanding column into a matrix, though datatype should not really matter for scatter-gather ops, should it?
Also, fix minor typo:
c10::ScalarType:Charis signed type, whereasc10::ScalarType::Byteis unsigned.Workarounds #82305 by aliasing tensors of
uint8types toint8typed ones