Use standard mechanism for stdlib names#81520
Closed
Erotemic wants to merge 3 commits intopytorch:masterfrom
Closed
Use standard mechanism for stdlib names#81520Erotemic wants to merge 3 commits intopytorch:masterfrom
Erotemic wants to merge 3 commits intopytorch:masterfrom
Conversation
Contributor
🔗 Helpful links
❌ 1 New Failures, 32 PendingAs of commit 500b434 (more details on the Dr. CI page): Expand to see more
🕵️ 1 new failure recognized by patternsThe following CI failures do not appear to be due to upstream breakages
|
Contributor
Author
malfet
approved these changes
Jul 15, 2022
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
Looks good to me, but please fix lint (apply the suggested edits)
Fixes lint
Contributor
Author
|
Looks like the linter is still upset? Not sure what to do with this: |
Contributor
@Erotemic it wants 2 spaces before |
malfet
reviewed
Jul 15, 2022
Contributor
|
@pytorchbot merge -f |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
Contributor
|
Hey @Erotemic. |
Contributor
Author
|
I don't see a way I can add the topic: not user facing label |
Contributor
|
I've just added it, but it's not too important. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 18, 2022
Summary: I noticed that in #81261 all of the stdlib module names were explicitly listed, however as of Python 3.10 the stdlib now has a mechanism for this. python/cpython#87121 I figured it was better to use `sys.stdlib_module_names` going forward for 3.10+ instead of having to maintain this file for every new Python release. For docs see: https://docs.python.org/3/library/sys.html#sys.stdlib_module_names I did a symmetric difference to determine what the effective change would be. I verified that everything listed in this file ins included in sys.stdlib_module_names. However, there are files in sys.stdlib_module_names that are not included in the previous hard coded definition. Namely these are: ``` frozenset({'__future__', '_abc', '_aix_support', '_asyncio', '_bisect', '_blake2', '_bootsubprocess', '_bz2', '_codecs', '_codecs_cn', '_codecs_hk', '_codecs_iso2022', '_codecs_jp', '_codecs_kr', '_codecs_tw', '_collections', '_collections_abc', '_compat_pickle', '_compression', '_contextvars', '_crypt', '_csv', '_ctypes', '_curses', '_curses_panel', '_datetime', '_dbm', '_decimal', '_elementtree', '_frozen_importlib', '_frozen_importlib_external', '_functools', '_gdbm', '_hashlib', '_heapq', '_imp', '_io', '_json', '_locale', '_lsprof', '_lzma', '_markupbase', '_md5', '_msi', '_multibytecodec', '_multiprocessing', '_opcode', '_operator', '_osx_support', '_overlapped', '_pickle', '_posixshmem', '_posixsubprocess', '_py_abc', '_pydecimal', '_pyio', '_queue', '_random', '_scproxy', '_sha1', '_sha256', '_sha3', '_sha512', '_signal', '_sitebuiltins', '_socket', '_sqlite3', '_sre', '_ssl', '_stat', '_statistics', '_string', '_strptime', '_struct', '_symtable', '_threading_local', '_tkinter', '_tracemalloc', '_uuid', '_warnings', '_weakref', '_weakrefset', '_winapi', '_zoneinfo', 'antigravity', 'genericpath', 'idlelib', 'nt', 'nturl2path', 'opcode', 'pydoc_data', 'pyexpat', 'this'}) ``` I'm not sure if excluding these matters. I wouldn't think it would, but if it does and it is better to explicitly update this file each time, then feel free to close this. Pull Request resolved: #81520 Approved by: https://github.com/malfet Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/4c9eae331b2695be011d96534a5ece44ba629601 Reviewed By: DanilBaibak Differential Revision: D37919540 Pulled By: DanilBaibak fbshipit-source-id: 6765556778ecad6edf254ad2ffc0d50d57ee1bbf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that in #81261 all of the stdlib module names were explicitly listed, however as of Python 3.10 the stdlib now has a mechanism for this. python/cpython#87121
I figured it was better to use
sys.stdlib_module_namesgoing forward for 3.10+ instead of having to maintain this file for every new Python release. For docs see:https://docs.python.org/3/library/sys.html#sys.stdlib_module_names
I did a symmetric difference to determine what the effective change would be. I verified that everything listed in this file ins included in sys.stdlib_module_names. However, there are files in sys.stdlib_module_names that are not included in the previous hard coded definition. Namely these are:
I'm not sure if excluding these matters. I wouldn't think it would, but if it does and it is better to explicitly update this file each time, then feel free to close this.