Skip to content

Conversation

@suo
Copy link
Member

@suo suo commented Jul 9, 2022

Stack from ghstack (oldest at bottom):

Reading the code this is actually pretty dope, but I don't think it's
used and we are retiring the S3 data pipeline, so removing.

We should probably resurrect a lot of this in the website which would
maybe make it more used.

Reading the code this is actually pretty dope, but I don't think it's
used and we are retiring the S3 data pipeline, so removing.

We should probably resurrect a lot of this in the website which would
maybe make it more used.

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2022

🔗 Helpful links

❌ 1 New Failures

As of commit d509fcb (more details on the Dr. CI page):

Expand to see more
  • 1/1 failures introduced in this PR

🕵️ 1 new failure recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (1/1)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-07-09T07:29:34.3582285Z The PR is introduc...m to confirm whether this change is wanted or not.
2022-07-09T07:29:34.3565664Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> int _0
2022-07-09T07:29:34.3567322Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> __torch__.torch.classes.profiling.SourceRef _0
2022-07-09T07:29:34.3569534Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0
2022-07-09T07:29:34.3570947Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-07-09T07:29:34.3573182Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-07-09T07:29:34.3574394Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-07-09T07:29:34.3576530Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> __torch__.torch.classes.profiling.SourceStats[] _0
2022-07-09T07:29:34.3578166Z processing existing schema:  __init__(__torch__.torch.classes.c10d.ProcessGroup _0, int _1, int _2) -> NoneType _0
2022-07-09T07:29:34.3579696Z processing existing schema:  __init__(__torch__.torch.classes.c10d.Work _0) -> NoneType _0
2022-07-09T07:29:34.3581646Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> NoneType _0
2022-07-09T07:29:34.3582285Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-07-09T07:29:34.3582315Z 
2022-07-09T07:29:34.3582417Z Broken ops: [
2022-07-09T07:29:34.3582714Z 	__getstate__(__torch__.torch.classes.sparse.LinearPackedParamsBase _0) -> ((Tensor, Tensor?, int[]) _0)
2022-07-09T07:29:34.3583013Z 	__setstate__(__torch__.torch.classes.sparse.LinearPackedParamsBase _0, (Tensor, Tensor?, int[]) _1) -> NoneType _0
2022-07-09T07:29:34.3583072Z ]
2022-07-09T07:29:34.4759991Z ##[error]Process completed with exit code 1.
2022-07-09T07:29:34.4793480Z Prepare all required actions
2022-07-09T07:29:34.4793774Z Getting action download info
2022-07-09T07:29:34.6264449Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-07-09T07:29:34.6264668Z with:

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

Reading the code this is actually pretty dope, but I don't think it's
used and we are retiring the S3 data pipeline, so removing.

We should probably resurrect a lot of this in the website which would
maybe make it more used.

[ghstack-poisoned]
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol same comments as #81164

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Sep 9, 2022
@facebook-github-bot
Copy link
Contributor

/easycla

As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details.

This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 4, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot closed this Nov 3, 2022
@facebook-github-bot facebook-github-bot deleted the gh/suo/590/head branch June 8, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants