Skip to content

[ci] remove dead code related to test selection #81163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
suo wants to merge 2 commits into from
Closed

[ci] remove dead code related to test selection #81163

suo wants to merge 2 commits into from

Conversation

@suo
Copy link
Member

@suo suo commented Jul 9, 2022 •
edited
Loading

@suo
[ci] remove dead code related to test selection
98aab9a 
Since we are using Rockset for all this now, remove the code that used
the S3 path.

[ghstack-poisoned]
@suo suo mentioned this pull request Jul 9, 2022
Closed
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jul 9, 2022 •
edited
Loading

🔗 Helpful links

❌ 2 New Failures

As of commit f50e6c6 (more details on the Dr. CI page):

Expand to see more
  • 2/2 failures introduced in this PR

🕵️ 2 new failures recognized by patterns

The following CI failures do not appear to be due to upstream breakages

See GitHub Actions build pull / linux-bionic-py3_7-clang8-xla / test (xla, 1, 1, linux.2xlarge) (1/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-07-09T07:26:04.4802177Z ##[error]Process completed with exit code 1. 
2022-07-09T07:26:04.4766183Z Non-cacheable calls                   0
2022-07-09T07:26:04.4766762Z Non-compilation calls                 0
2022-07-09T07:26:04.4766986Z Unsupported compiler calls            0
2022-07-09T07:26:04.4767205Z Average cache write               0.000 s
2022-07-09T07:26:04.4767408Z Average cache read miss           0.000 s
2022-07-09T07:26:04.4767620Z Average cache read hit            0.000 s
2022-07-09T07:26:04.4767844Z Failed distributed compilations       0
2022-07-09T07:26:04.4768388Z Cache location                  S3, bucket: Bucket(name=ossci-compiler-cache-circleci-v2, base_url=http://ossci-compiler-cache-circleci-v2.s3.amazonaws.com/)
2022-07-09T07:26:04.4768890Z + echo ::endgroup::
2022-07-09T07:26:04.4769466Z ##[endgroup]
2022-07-09T07:26:04.4802177Z ##[error]Process completed with exit code 1.
2022-07-09T07:26:04.4836901Z Prepare all required actions
2022-07-09T07:26:04.4837180Z Getting action download info
2022-07-09T07:26:04.6365432Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-07-09T07:26:04.6365660Z with:
2022-07-09T07:26:04.6365989Z   github-token: ***
2022-07-09T07:26:04.6366142Z env:
2022-07-09T07:26:04.6366313Z   GIT_DEFAULT_BRANCH: master
2022-07-09T07:26:04.6366496Z ##[endgroup]
2022-07-09T07:26:04.6391593Z ##[group]Run nick-fields/retry@71062288b76e2b6214ebde0e673ce0de1755740a
2022-07-09T07:26:04.6391831Z with:

See GitHub Actions build pull / linux-focal-py3.7-gcc7 / test (backwards_compat, 1, 1, linux.2xlarge) (2/2)

Step: "Test" (full log | diagnosis details | 🔁 rerun)

2022-07-09T07:36:57.3483193Z The PR is introduc...m to confirm whether this change is wanted or not. 
2022-07-09T07:36:57.3466053Z processing existing schema:  duration_ns(__torch__.torch.classes.profiling.InstructionStats _0) -> int _0
2022-07-09T07:36:57.3467996Z processing existing schema:  source(__torch__.torch.classes.profiling.SourceStats _0) -> __torch__.torch.classes.profiling.SourceRef _0
2022-07-09T07:36:57.3470461Z processing existing schema:  line_map(__torch__.torch.classes.profiling.SourceStats _0) -> Dict(int, __torch__.torch.classes.profiling.InstructionStats) _0
2022-07-09T07:36:57.3472112Z processing existing schema:  __init__(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-07-09T07:36:57.3473709Z processing existing schema:  enable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-07-09T07:36:57.3475217Z processing existing schema:  disable(__torch__.torch.classes.profiling._ScriptProfile _0) -> NoneType _0
2022-07-09T07:36:57.3477464Z processing existing schema:  _dump_stats(__torch__.torch.classes.profiling._ScriptProfile _0) -> __torch__.torch.classes.profiling.SourceStats[] _0
2022-07-09T07:36:57.3479055Z processing existing schema:  __init__(__torch__.torch.classes.c10d.ProcessGroup _0, int _1, int _2) -> NoneType _0
2022-07-09T07:36:57.3480527Z processing existing schema:  __init__(__torch__.torch.classes.c10d.Work _0) -> NoneType _0
2022-07-09T07:36:57.3482372Z processing existing schema:  __init__(__torch__.torch.classes.dist_rpc.WorkerInfo _0, str _1, int _2) -> NoneType _0
2022-07-09T07:36:57.3483193Z The PR is introducing backward incompatible changes to the operator library. Please contact PyTorch team to confirm whether this change is wanted or not. 
2022-07-09T07:36:57.3483445Z 
2022-07-09T07:36:57.3483520Z Broken ops: [
2022-07-09T07:36:57.3483900Z 	__getstate__(__torch__.torch.classes.sparse.LinearPackedParamsBase _0) -> ((Tensor, Tensor?, int[]) _0)
2022-07-09T07:36:57.3484398Z 	__setstate__(__torch__.torch.classes.sparse.LinearPackedParamsBase _0, (Tensor, Tensor?, int[]) _1) -> NoneType _0
2022-07-09T07:36:57.3484677Z ]
2022-07-09T07:36:57.4682552Z ##[error]Process completed with exit code 1.
2022-07-09T07:36:57.4712678Z Prepare all required actions
2022-07-09T07:36:57.4712963Z Getting action download info
2022-07-09T07:36:57.6010214Z ##[group]Run ./.github/actions/get-workflow-job-id
2022-07-09T07:36:57.6010498Z with:
This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

This was referenced Jul 9, 2022
Closed
Closed
Closed
@suo
Update on "[ci] remove dead code related to test selection"
f50e6c6 
Since we are using Rockset for all this now, remove the code that used
the S3 path.

[ghstack-poisoned]
janeyx99
janeyx99 approved these changes Jul 11, 2022
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@suo
Copy link
Member Author

suo commented Jul 12, 2022

@pytorchbot merge -f

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jul 12, 2022

@pytorchbot successfully started a merge job. Check the current status here

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2022

Hey @suo.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

facebook-github-bot pushed a commit that referenced this pull request Jul 12, 2022
@suo @facebook-github-bot
[ci] remove dead code related to test selection (#81163) (#81163)
d9f5399 
Summary:
Since we are using Rockset for all this now, remove the code that used
the S3 path.

Pull Request resolved: #81163
Approved by: https://github.com/janeyx99

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/d321be61c07bc1201c7fe10cd03d045277a326c1

Reviewed By: DanilBaibak

Differential Revision: D37782047

Pulled By: suo

fbshipit-source-id: 53d0e40ad7601114a17b91c21eba67165f2736f0
@facebook-github-bot facebook-github-bot deleted the gh/suo/588/head branch July 15, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

cla signed Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@suo @facebook-github-bot @pytorchmergebot @janeyx99