switch Bazel to common aten codegen #79783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit a104d89 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
This was referenced Jun 17, 2022
added 6 commits
June 20, 2022 08:09
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
Closed
added 2 commits
July 8, 2022 07:25
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
We can also clean up the other rule generation. This is removing support for per-operator headers right now. We don't take advantage of that internally, so it's better to have the Bazel build compatible with our internal builds. Differential Revision: [D36489359](https://our.internmc.facebook.com/intern/diff/D36489359/) **NOTE FOR REVIEWERS**: This PR has internal Facebook specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D36489359/)! [ghstack-poisoned]
Contributor
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Contributor
|
/easycla As part of the transition to the PyTorch Foundation, this project now requires contributions be covered under the new CLA. See #85559 for additional details. This comment will trigger a new check of this PR. If you are already covered, you will simply see a new "EasyCLA" check that passes. If you are not covered, a bot will leave a new comment with a link to sign. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We can also clean up the other rule generation. This is removing
support for per-operator headers right now. We don't take advantage of
that internally, so it's better to have the Bazel build compatible
with our internal builds.
Differential Revision: D36489359
NOTE FOR REVIEWERS: This PR has internal Facebook specific changes or comments, please review them on Phabricator!