[c10d] Make gather as a custom op#79687
Closed
alanwaketan wants to merge 2 commits intogh/alanwaketan/38/basefrom
Closed
[c10d] Make gather as a custom op#79687alanwaketan wants to merge 2 commits intogh/alanwaketan/38/basefrom
alanwaketan wants to merge 2 commits intogh/alanwaketan/38/basefrom
Conversation
Summary: This patch makes gather as a custom op such that it's dispatcher passable. It's one part of the effort to route comm ops to the dispatcher such that tracing mechanisms that relies on the dispatcher can trace them, e.g., LazyTensor and AOTAutograd. Test Plan: python test/distributed/test_c10d_nccl.py -k test_gather_ops python test/distributed/test_c10d_gloo.py -k test_gather_basics ...and other existing distributed tests. [ghstack-poisoned]
alanwaketan
requested review from
H-Huang,
awgu,
mingzhe09088,
mrshenli,
pritamdamania87,
rohan-varma and
zhaojuanmao
as code owners
This was referenced Jun 16, 2022
Contributor
🔗 Helpful links
✅ No Failures (0 Pending)As of commit 4a5c218 (more details on the Dr. CI page): Expand to see more💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
added
the
oncall: distributed
alanwaketan
pushed a commit
that referenced
this pull request
Jun 16, 2022
Summary: This patch makes gather as a custom op such that it's dispatcher passable. It's one part of the effort to route comm ops to the dispatcher such that tracing mechanisms that relies on the dispatcher can trace them, e.g., LazyTensor and AOTAutograd. Test Plan: python test/distributed/test_c10d_nccl.py -k test_gather_ops python test/distributed/test_c10d_gloo.py -k test_gather_basics ...and other existing distributed tests. ghstack-source-id: 0e63c05 Pull Request resolved: #79687
alanwaketan
removed request for
H-Huang,
awgu,
mingzhe09088,
mrshenli,
rohan-varma and
zhaojuanmao
This was referenced Jun 16, 2022
This was referenced Jun 17, 2022
Summary: This patch makes gather as a custom op such that it's dispatcher passable. It's one part of the effort to route comm ops to the dispatcher such that tracing mechanisms that relies on the dispatcher can trace them, e.g., LazyTensor and AOTAutograd. Test Plan: python test/distributed/test_c10d_nccl.py -k test_gather_ops python test/distributed/test_c10d_gloo.py -k test_gather_basics ...and other existing distributed tests. [ghstack-poisoned]
mrshenli
approved these changes
Jun 24, 2022
| .def( | ||
| "gather", | ||
| [](::c10d::ProcessGroup& pg, | ||
| [](const c10::intrusive_ptr<::c10d::ProcessGroup>& pg, |
Collaborator
Author
There was a problem hiding this comment.
Let me follow up on #80246. Thanks for approving.
alanwaketan
added
release notes: distributed (c10d)
Collaborator
Author
|
@pytorchbot merge |
Collaborator
|
@pytorchbot successfully started a merge job. Check the current status here |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Summary: This patch makes gather as a custom op such that it's dispatcher passable. It's one part of the effort to route comm ops to the dispatcher such that tracing mechanisms that relies on the dispatcher can trace them, e.g., LazyTensor and AOTAutograd. Pull Request resolved: #79687 Approved by: https://github.com/mrshenli Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/9d6e3f81d46382ed91b6ff286efe07e5cf5dd052 Test plan from GitHub: python test/distributed/test_c10d_nccl.py -k test_gather_ops python test/distributed/test_c10d_gloo.py -k test_gather_basics ...and other existing distributed tests. Reviewed By: atalman Differential Revision: D37455701 Pulled By: alanwaketan fbshipit-source-id: 9322466cc8652789ccd77d8ed13e10958e85b101
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
This patch makes gather as a custom op such that it's dispatcher
passable. It's one part of the effort to route comm ops to the dispatcher
such that tracing mechanisms that relies on the dispatcher can trace them,
e.g., LazyTensor and AOTAutograd.
Test Plan:
python test/distributed/test_c10d_nccl.py -k test_gather_ops
python test/distributed/test_c10d_gloo.py -k test_gather_basics
...and other existing distributed tests.