Updating miniz library from version 2.0.8 -> 2.1.0 #79636

MdAamirRaihan · 2022-06-15T19:46:16Z

Summary:
This PR updates the miniz library from version 2.0.8 to 2.1.0.

facebook-github-bot · 2022-06-15T19:46:20Z

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot · 2022-06-15T19:46:23Z

🔗 Helpful links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/79636
📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓Need help or want to give feedback on the CI? Visit our office hours

✅ No Failures (0 Pending)

As of commit e7fd9b4 (more details on the Dr. CI page):

Expand to see more

💚 💚 Looks good so far! There are no failures yet. 💚 💚

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

albanD · 2022-06-21T13:44:47Z

Hi,

Why do you want to do this update?

MdAamirRaihan · 2022-06-21T20:04:17Z

Hi,

Why do you want to do this update?

The miniz library symbol is publicly exposed and causing some internal conflict with our (microsoft) software stack . Therefore updating the miniz to a newer (same) version.

Besides we are updating it to a new version so all the new functionality available in miniz-2.1.0 will be available and this update is not causing any regression problem so I think we can merge it.

albanD · 2022-06-21T20:14:04Z

Could please take care of the CLA before this can be merged?

cc @malfet

MdAamirRaihan · 2022-06-21T21:10:05Z

Could please take care of the CLA before this can be merged?

cc @malfet

Just signed the CLA

albanD · 2022-06-21T22:34:25Z

It seems that the CLA was registered as the bot didn't post here.
Can you double check that you did it with the right github handle/email as the one on your github account?

MdAamirRaihan · 2022-06-21T22:44:22Z

It seems that the CLA was registered as the bot didn't post here. Can you double check that you did it with the right github handle/email as the one on your github account?

Yes, I did it with the correct email and account name.

It seems that I had to push something on the PR to re-trigger the bot.

facebook-github-bot · 2022-06-21T22:48:13Z

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

albanD

SGTM thanks for the update

albanD · 2022-06-22T14:53:30Z

@pytorchbot merge

pytorchmergebot · 2022-06-22T15:02:12Z

@pytorchbot successfully started a merge job. Check the current status here

pytorchmergebot · 2022-06-22T15:02:19Z

@MdAamirRaihan your PR has been successfully merged.

github-actions · 2022-06-22T15:03:01Z

Hey @MdAamirRaihan.
You've committed this PR, but it does not have both a 'release notes: ...' and 'topics: ...' label. Please add one of each to the PR. The 'release notes: ...' label should represent the part of PyTorch that this PR changes (fx, autograd, distributed, etc) and the 'topics: ...' label should represent the kind of PR it is (not user facing, new feature, bug fix, perf improvement, etc). The list of valid labels can be found here for the 'release notes: ...' and here for the 'topics: ...'.
For changes that are 'topic: not user facing' there is no need for a release notes label.

Summary: This PR updates the miniz library from version 2.0.8 to 2.1.0. Pull Request resolved: #79636 Approved by: https://github.com/albanD

Summary: This PR updates the miniz library from version 2.0.8 to 2.1.0. Pull Request resolved: #79636 Approved by: https://github.com/albanD Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/7ea723b8f65fa176732f61923a2b88d77a2f105a Reviewed By: albanD Differential Revision: D37349351 Pulled By: albanD fbshipit-source-id: ffff533cc6d93f15a3620139fb5a9fd8fbc68b2d

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

…d patch for zip64" Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]

…d patch for zip64" Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D65586230](https://our.internmc.facebook.com/intern/diff/D65586230) [ghstack-poisoned]

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: Differential Revision: [D65586230](https://our.internmc.facebook.com/intern/diff/D65586230) [ghstack-poisoned]

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 4501669 Pull Request resolved: #139985

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Imported from OSS Differential Revision: D65586230

Summary: Pull Request resolved: #140041 Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Imported from OSS Differential Revision: D65586230

Summary: Pull Request resolved: #140041 Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Imported from OSS Reviewed By: mikaylagawarecki, angelayi Differential Revision: D65586230

Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * #79636 patches internal BUCK and bazel build * #138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Imported from OSS Differential Revision: D65586230 Pull Request resolved: #140041 Approved by: https://github.com/mikaylagawarecki

…140041) Summary: Bump miniz version from 2.1.0 to 3.0.2 and apply these patches: * pytorch#79636 patches internal BUCK and bazel build * pytorch#138959 adds `bool compute_crc32` argument * miniz PR: richgel999/miniz#324 to support zip64 Anyone bumping miniz version again, please apply these patches as well. Test Plan: Rely on unit test Imported from OSS Differential Revision: D65586230 Pull Request resolved: pytorch#140041 Approved by: https://github.com/mikaylagawarecki

pytorchbot added the open source label Jun 15, 2022

MdAamirRaihan force-pushed the updating-miniz branch from 7b9a510 to 8df3385 Compare June 15, 2022 23:33

albanD added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jun 21, 2022

MdAamirRaihan added 4 commits June 21, 2022 15:47

Updating miniz library from version 2.0.8 to 2.1.0

22f3a4b

Added NOLINTNEXTLINE for disabling clang-tidy warning messages

1485d92

Addressing the build failure

bd632c3

Addressing the build failure

e7fd9b4

MdAamirRaihan force-pushed the updating-miniz branch from c1802ce to e7fd9b4 Compare June 21, 2022 22:48

facebook-github-bot added the cla signed label Jun 21, 2022

albanD approved these changes Jun 22, 2022

View reviewed changes

pytorchmergebot added the Merged label Jun 22, 2022

pytorchmergebot closed this in 7ea723b Jun 22, 2022

malfet mentioned this pull request Jun 22, 2022

Heap buffer overflow in third_party: miniz-2.0.8 #74798

Closed

larryliu0820 mentioned this pull request Nov 7, 2024

[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #139985

Closed

larryliu0820 mentioned this pull request Nov 7, 2024

[miniz] Bump miniz version to 3.0.2 and add patch for zip64 #140041

Closed

Updating miniz library from version 2.0.8 -> 2.1.0 #79636

Updating miniz library from version 2.0.8 -> 2.1.0 #79636

Uh oh!

Conversation

MdAamirRaihan commented Jun 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 15, 2022

Action Required

Process

Uh oh!

facebook-github-bot commented Jun 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful links

✅ No Failures (0 Pending)

Uh oh!

albanD commented Jun 21, 2022

Uh oh!

MdAamirRaihan commented Jun 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

albanD commented Jun 21, 2022

Uh oh!

MdAamirRaihan commented Jun 21, 2022

Uh oh!

albanD commented Jun 21, 2022

Uh oh!

MdAamirRaihan commented Jun 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Jun 21, 2022

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

albanD commented Jun 22, 2022

Uh oh!

pytorchmergebot commented Jun 22, 2022

Uh oh!

pytorchmergebot commented Jun 22, 2022

Uh oh!

github-actions bot commented Jun 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MdAamirRaihan commented Jun 15, 2022 •

edited

Loading

facebook-github-bot commented Jun 15, 2022 •

edited

Loading

MdAamirRaihan commented Jun 21, 2022 •

edited

Loading

MdAamirRaihan commented Jun 21, 2022 •

edited

Loading